Skip to content

Several modifications #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 12, 2014
Merged

Several modifications #367

merged 6 commits into from
Feb 12, 2014

Conversation

cli248
Copy link
Contributor

@cli248 cli248 commented Feb 12, 2014

See details on the changed files.

@@ -104,6 +104,8 @@ Pro Python
This book is for intermediate to advanced Python programmers who are looking to understand how
and why Python works the way it does and how they can take their code to the next level.

`Pro Python <http://propython.com>`_
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please collapse remove this and make This book at the beginning of the preceding paragraph the link.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sigmavirus24, it seems the other suggested books, i.e., Python Koans, A Byte of Python, Expert Python, they don't have the link at the beginning of the preceding paragraph. That is why I put the Pro Python link at the line 107, which is consistent with other books.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, good call. I had forgotten about that.

@sigmavirus24
Copy link
Contributor

In the future, I would appreciate more PRs with a narrower focus personally. That aside, thanks for this! 🍰

sigmavirus24 added a commit that referenced this pull request Feb 12, 2014
@sigmavirus24 sigmavirus24 merged commit 09de7cb into realpython:master Feb 12, 2014
@cli248 cli248 deleted the update branch February 12, 2014 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants