From 5d0541cbea29b84d336280293ea8579412d2f8e9 Mon Sep 17 00:00:00 2001 From: Marc Poulin Date: Mon, 24 Sep 2018 13:52:20 -0600 Subject: [PATCH 1/4] Added missing comma --- docs/writing/reading.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/writing/reading.rst b/docs/writing/reading.rst index a74b64b9c..135449a4b 100644 --- a/docs/writing/reading.rst +++ b/docs/writing/reading.rst @@ -28,7 +28,7 @@ reading. Each one of these projects is a paragon of Python coding. - `Diamond `_ Diamond is a python daemon that collects metrics and publishes them to Graphite or other backends. - It is capable of collecting cpu, memory, network, i/o, load and disk metrics. + It is capable of collecting cpu, memory, network, i/o, load, and disk metrics. Additionally, it features an API for implementing custom collectors for gathering metrics from almost any source. From 3bdbae8d8c3a2f9ed383f26ddc83dffa4ad2c4e3 Mon Sep 17 00:00:00 2001 From: Marc Poulin Date: Mon, 24 Sep 2018 13:58:49 -0600 Subject: [PATCH 2/4] Fixed grammar. --- docs/writing/reading.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/writing/reading.rst b/docs/writing/reading.rst index 135449a4b..f06876de5 100644 --- a/docs/writing/reading.rst +++ b/docs/writing/reading.rst @@ -33,7 +33,7 @@ reading. Each one of these projects is a paragon of Python coding. for gathering metrics from almost any source. - `Werkzeug `_ - Werkzeug started as simple collection of various utilities for WSGI + Werkzeug started as a simple collection of various utilities for WSGI applications and has become one of the most advanced WSGI utility modules. It includes a powerful debugger, full-featured request and response objects, HTTP utilities to handle entity tags, cache control headers, HTTP dates, From 71b2afae2391707df8ac0c15662ab7b18f23d4fe Mon Sep 17 00:00:00 2001 From: Marc Poulin Date: Mon, 24 Sep 2018 14:29:11 -0600 Subject: [PATCH 3/4] Deleted first paragraph The subject of this section is finding examples of excellent code, not "readability matters". --- docs/writing/reading.rst | 4 ---- 1 file changed, 4 deletions(-) diff --git a/docs/writing/reading.rst b/docs/writing/reading.rst index f06876de5..1a8aff8f4 100644 --- a/docs/writing/reading.rst +++ b/docs/writing/reading.rst @@ -3,10 +3,6 @@ Reading Great Code .. image:: /_static/photos/34689452831_93d7fd0571_k_d.jpg -One of the core tenets behind the design of Python is creating -readable code. The motivation behind this design is simple: The number -one thing that Python programmers do is read code. - One of the secrets of becoming a great Python programmer is to read, understand, and comprehend excellent code. From 29be1ba532bab23b6251bbbd82b5c777ed22dd41 Mon Sep 17 00:00:00 2001 From: Marc Poulin Date: Tue, 25 Sep 2018 13:36:31 -0600 Subject: [PATCH 4/4] Capitalize CPU and I/O --- docs/writing/reading.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/writing/reading.rst b/docs/writing/reading.rst index 1a8aff8f4..5c53d97bf 100644 --- a/docs/writing/reading.rst +++ b/docs/writing/reading.rst @@ -24,7 +24,7 @@ reading. Each one of these projects is a paragon of Python coding. - `Diamond `_ Diamond is a python daemon that collects metrics and publishes them to Graphite or other backends. - It is capable of collecting cpu, memory, network, i/o, load, and disk metrics. + It is capable of collecting CPU, memory, network, I/O, load, and disk metrics. Additionally, it features an API for implementing custom collectors for gathering metrics from almost any source.