Use six.string_types for topic type check in dpkp#824

dpkp · dpkp · commit c4a6e1aa68fc · 2016-11-20T12:44:55.000-08:00
diff --git a/kafka/consumer/subscription_state.py b/kafka/consumer/subscription_state.py
@@ -133,15 +133,15 @@ def change_subscription(self, topics):
         if self._user_assignment:
             raise IllegalStateError(self._SUBSCRIPTION_EXCEPTION_MESSAGE)
 
-        if isinstance(topics, str):
+        if isinstance(topics, six.string_types):
             topics = [topics]
 
         if self.subscription == set(topics):
             log.warning("subscription unchanged by change_subscription(%s)",
                         topics)
             return
 
-        if any(not isinstance(t, str) for t in topics):
+        if any(not isinstance(t, six.string_types) for t in topics):
             raise TypeError('All topics must be strings')
 
         log.info('Updating subscribed topics to: %s', topics)
