Skip to content

Commit bd45473

Browse files
sofislmctavish
andauthored
chore!: upgrade to node 14 (googleapis#1160)
* chore!: upgrade to node 14 --------- Co-authored-by: James McTavish <mctavish@google.com>
1 parent f8815fc commit bd45473

File tree

13 files changed

+19
-116
lines changed

13 files changed

+19
-116
lines changed

.github/sync-repo-settings.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,9 @@ branchProtectionRules:
99
- "ci/kokoro: System test"
1010
- docs
1111
- lint
12-
- test (12)
1312
- test (14)
1413
- test (16)
14+
- test (18)
1515
- cla/google
1616
- windows
1717
- OwlBot Post Processor

.github/workflows/ci.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ jobs:
99
runs-on: ubuntu-latest
1010
strategy:
1111
matrix:
12-
node: [12, 14, 16]
12+
node: [14, 16, 18, 20]
1313
steps:
1414
- uses: actions/checkout@v3
1515
- uses: actions/setup-node@v3

.kokoro/continuous/node12/common.cfg

-24
This file was deleted.

.kokoro/continuous/node12/lint.cfg

-4
This file was deleted.

.kokoro/continuous/node12/samples-test.cfg

-12
This file was deleted.

.kokoro/continuous/node12/system-test.cfg

-12
This file was deleted.

.kokoro/continuous/node12/test.cfg

Whitespace-only changes.

.kokoro/presubmit/node12/common.cfg

-24
This file was deleted.

.kokoro/presubmit/node12/samples-test.cfg

-12
This file was deleted.

.kokoro/presubmit/node12/system-test.cfg

-12
This file was deleted.

.kokoro/presubmit/node12/test.cfg

Whitespace-only changes.

package.json

+5-5
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
],
2020
"license": "Apache-2.0",
2121
"engines": {
22-
"node": ">=12.0.0"
22+
"node": ">=14.0.0"
2323
},
2424
"files": [
2525
"build/src"
@@ -44,15 +44,15 @@
4444
"precompile": "gts clean"
4545
},
4646
"dependencies": {
47-
"@google-cloud/common": "^4.0.0",
47+
"@google-cloud/common": "^5.0.0",
4848
"@fastify/busboy": "1.1.0",
4949
"acorn": "^8.0.0",
5050
"coffeescript": "^2.0.0",
5151
"console-log-level": "^1.4.0",
5252
"extend": "^3.0.2",
5353
"findit2": "^2.2.3",
5454
"firebase-admin": "^10.0.0",
55-
"gcp-metadata": "^5.0.0",
55+
"gcp-metadata": "^6.0.0",
5656
"p-limit": "^3.0.1",
5757
"semver": "^7.0.0",
5858
"source-map": "^0.8.0-beta.0",
@@ -81,7 +81,7 @@
8181
"cpy-cli": "^4.0.0",
8282
"cross-env": "^7.0.0",
8383
"execa": "^5.0.0",
84-
"gts": "^3.1.0",
84+
"gts": "^5.0.0",
8585
"linkinator": "^4.0.0",
8686
"mocha": "^9.2.2",
8787
"mv": "^2.1.1",
@@ -91,7 +91,7 @@
9191
"proxyquire": "^2.0.0",
9292
"teeny-request": "^8.0.0",
9393
"tmp-promise": "^3.0.0",
94-
"typescript": "^4.6.4",
94+
"typescript": "5.1.6",
9595
"uuid": "^9.0.0"
9696
}
9797
}

src/agent/debuglet.ts

+12-9
Original file line numberDiff line numberDiff line change
@@ -1049,15 +1049,18 @@ export class Debuglet extends EventEmitter {
10491049
: now;
10501050
const expiryTime = createdTime + this.config.breakpointExpirationSec;
10511051

1052-
setTimeout(() => {
1053-
this.logger.info('Expiring breakpoint ' + breakpoint.id);
1054-
breakpoint.status = {
1055-
description: {format: 'The snapshot has expired'},
1056-
isError: true,
1057-
refersTo: StatusMessage.BREAKPOINT_AGE,
1058-
};
1059-
this.completeBreakpoint_(breakpoint);
1060-
}, (expiryTime - now) * 1000).unref();
1052+
setTimeout(
1053+
() => {
1054+
this.logger.info('Expiring breakpoint ' + breakpoint.id);
1055+
breakpoint.status = {
1056+
description: {format: 'The snapshot has expired'},
1057+
isError: true,
1058+
refersTo: StatusMessage.BREAKPOINT_AGE,
1059+
};
1060+
this.completeBreakpoint_(breakpoint);
1061+
},
1062+
(expiryTime - now) * 1000
1063+
).unref();
10611064
}
10621065

10631066
/**

0 commit comments

Comments
 (0)