Expose target to make comlink compatible with proxy-polyfill (GoogleChromeLabs#389)

surma · web-flow · commit 96d11972f7e1 · 2019-11-06T12:18:28.000Z
Expose target to make comlink compatible  with proxy-polyfill
diff --git a/src/comlink.ts b/src/comlink.ts
@@ -202,8 +202,8 @@ function closeEndPoint(endpoint: Endpoint) {
   if (isMessagePort(endpoint)) endpoint.close();
 }
 
-export function wrap<T>(ep: Endpoint): Remote<T> {
-  return createProxy<T>(ep) as any;
+export function wrap<T>(ep: Endpoint, target?: any): Remote<T> {
+  return createProxy<T>(ep, [], target) as any;
 }
 
 function throwIfProxyReleased(isReleased: boolean) {
@@ -214,10 +214,11 @@ function throwIfProxyReleased(isReleased: boolean) {
 
 function createProxy<T>(
   ep: Endpoint,
-  path: (string | number | symbol)[] = []
+  path: (string | number | symbol)[] = [],
+  target: object = function() {}
 ): Remote<T> {
   let isProxyReleased = false;
-  const proxy = new Proxy(function() {}, {
+  const proxy = new Proxy(target, {
     get(_target, prop) {
       throwIfProxyReleased(isProxyReleased);
       if (prop === releaseProxy) {
diff --git a/tests/same_window.comlink.test.js b/tests/same_window.comlink.test.js
@@ -518,6 +518,12 @@ describe("Comlink in the same realm", function() {
     await instance[Comlink.releaseProxy]();
     expect(() => instance.method()).to.throw();
   });
+
+  it('can proxy with a given target', async function() {
+    const thing = Comlink.wrap(this.port1, { value: {} });
+    Comlink.expose({ value: 4 }, this.port2);
+    expect(await thing.value).to.equal(4);
+  });
 });
 
 function guardedIt(f) {
