Add support for srcache_store_max_size

Andre · Andre · commit e7677b261796 · 2011-04-12T16:12:50.000+02:00
diff --git a/README b/README
@@ -94,6 +94,7 @@ Known Issues
                 set $key ...;
                 srcache_fetch GET /memc $key;
                 srcache_store PUT /memc $key;
+				srcache_store_max_size 1m;
 
                 # proxy_pass/fastcgi_pass/...
             }
@@ -114,7 +115,7 @@ Directives
 
     srcache_store
 
-    srcache_store_max_size (TODO)
+    srcache_store_max_size 
 
 Installation
     1. Grab the nginx source code from nginx.net (< http://nginx.net/ >), for
diff --git a/src/ngx_http_srcache_filter_module.c b/src/ngx_http_srcache_filter_module.c
@@ -70,6 +70,14 @@ static ngx_command_t  ngx_http_srcache_commands[] = {
       offsetof(ngx_http_srcache_loc_conf_t, store),
       NULL },
 
+    { ngx_string("srcache_store_max_size"),
+      NGX_HTTP_MAIN_CONF|NGX_HTTP_SRV_CONF|NGX_HTTP_LOC_CONF|NGX_HTTP_LIF_CONF
+          |NGX_CONF_TAKE1,
+      ngx_conf_set_size_slot,
+      NGX_HTTP_LOC_CONF_OFFSET,
+      offsetof(ngx_http_srcache_loc_conf_t, store_max_size),
+      NULL },
+
       ngx_null_command
 };
 
@@ -197,6 +205,14 @@ ngx_http_srcache_header_filter(ngx_http_request_t *r)
         return ngx_http_next_header_filter(r);
     }
 
+	if (slcf->store_max_size != NGX_CONF_UNSET_SIZE 
+			&& r->headers_out.content_length_n >= (int) slcf->store_max_size) {
+		ngx_log_debug1(NGX_LOG_DEBUG_HTTP, r->connection->log, 0, 
+				"bypass because of too large content: %d (limit is: %d)", 
+				r->headers_out.content_length, slcf->store_max_size);
+		return ngx_http_next_header_filter(r);
+	}
+
     dd("try to save the response header");
 
     if (r != r->main) {
@@ -457,6 +473,8 @@ ngx_http_srcache_create_loc_conf(ngx_conf_t *cf)
 
     slcf->buf_size = NGX_CONF_UNSET_SIZE;
 
+	slcf->store_max_size = NGX_CONF_UNSET_SIZE;
+
     return slcf;
 }
 
@@ -473,6 +491,9 @@ ngx_http_srcache_merge_loc_conf(ngx_conf_t *cf, void *parent, void *child)
     ngx_conf_merge_size_value(conf->buf_size, prev->buf_size,
             (size_t) ngx_pagesize);
 
+    ngx_conf_merge_size_value(conf->store_max_size, prev->store_max_size, 
+			NGX_CONF_UNSET_SIZE);
+
     return NGX_CONF_OK;
 }
 
diff --git a/src/ngx_http_srcache_filter_module.h b/src/ngx_http_srcache_filter_module.h
@@ -29,6 +29,7 @@ typedef struct {
     ngx_http_srcache_request_t      *fetch;
     ngx_http_srcache_request_t      *store;
     size_t                           buf_size;
+	size_t							 store_max_size;
 
     unsigned              postponed_to_access_phase_end;
 } ngx_http_srcache_loc_conf_t;
