Remove useless code

matyhtf · matyhtf · commit b64d2f24e5db · 2021-06-03T13:52:50.000+08:00
diff --git a/ext-src/swoole_client_coro.cc b/ext-src/swoole_client_coro.cc
@@ -526,7 +526,6 @@ static PHP_METHOD(swoole_client_coro, connect) {
     Z_PARAM_OPTIONAL
     Z_PARAM_LONG(port)
     Z_PARAM_DOUBLE(timeout)
-    Z_PARAM_LONG(sock_flag)
     ZEND_PARSE_PARAMETERS_END_EX(RETURN_FALSE);
 
     if (host_len == 0) {
@@ -553,7 +552,7 @@ static PHP_METHOD(swoole_client_coro, connect) {
     }
 
     cli->set_timeout(timeout, Socket::TIMEOUT_CONNECT);
-    if (!cli->connect(host, port, sock_flag)) {
+    if (!cli->connect(host, port)) {
         zend_update_property_long(swoole_client_coro_ce, SW_Z8_OBJ_P(ZEND_THIS), ZEND_STRL("errCode"), cli->errCode);
         zend_update_property_string(swoole_client_coro_ce, SW_Z8_OBJ_P(ZEND_THIS), ZEND_STRL("errMsg"), cli->errMsg);
         client_coro_close(ZEND_THIS);
diff --git a/include/swoole_coroutine_socket.h b/include/swoole_coroutine_socket.h
@@ -63,7 +63,7 @@ class Socket {
     Socket(enum swSocket_type type = SW_SOCK_TCP);
     Socket(int _fd, enum swSocket_type _type);
     ~Socket();
-    bool connect(std::string host, int port, int flags = 0);
+    bool connect(std::string host, int port);
     bool connect(const struct sockaddr *addr, socklen_t addrlen);
     bool shutdown(int how = SHUT_RDWR);
     bool cancel(const enum swEvent_type event);
diff --git a/src/coroutine/socket.cc b/src/coroutine/socket.cc
@@ -595,7 +595,7 @@ bool Socket::connect(const struct sockaddr *addr, socklen_t addrlen) {
     return true;
 }
 
-bool Socket::connect(std::string _host, int _port, int flags) {
+bool Socket::connect(std::string _host, int _port) {
     if (sw_unlikely(!is_available(SW_EVENT_RDWR))) {
         return false;
     }

Original file line number	Diff line number	Diff line change
`@@ -595,7 +595,7 @@ bool Socket::connect(const struct sockaddr *addr, socklen_t addrlen) {`
`595`	`595`	`return true;`
`596`	`596`	`}`
`597`	`597`
`598`		`-bool Socket::connect(std::string _host, int _port, int flags) {`
	`598`	`+bool Socket::connect(std::string _host, int _port) {`
`599`	`599`	`if (sw_unlikely(!is_available(SW_EVENT_RDWR))) {`
`600`	`600`	`return false;`
`601`	`601`	`}`