Skip to content

Commit c041895

Browse files
committed
Reduce duplication in [action]Start functions
1 parent 363d39c commit c041895

File tree

1 file changed

+24
-29
lines changed

1 file changed

+24
-29
lines changed

interact.js

Lines changed: 24 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -2291,10 +2291,15 @@
22912291
}
22922292

22932293
if (starting) {
2294-
actions[prepared].start(event);
2294+
prevEvent = actions[prepared].start(downEvent);
2295+
2296+
// set snapping for the next move event
2297+
if (target.options.snapEnabled && !target.options.snap.endOnly) {
2298+
setSnapping(event);
2299+
}
22952300
}
22962301

2297-
actions[prepared].move(event);
2302+
prevEvent = actions[prepared].move(event);
22982303
}
22992304
}
23002305
// if no snap, always move
@@ -2304,10 +2309,15 @@
23042309
}
23052310

23062311
if (starting) {
2307-
actions[prepared].start(event);
2312+
prevEvent = actions[prepared].start(downEvent);
2313+
2314+
// set snapping for the next move event
2315+
if (target.options.snapEnabled && !target.options.snap.endOnly) {
2316+
setSnapping(event);
2317+
}
23082318
}
23092319

2310-
actions[prepared].move(event);
2320+
prevEvent = actions[prepared].move(event);
23112321
}
23122322
}
23132323
}
@@ -2409,7 +2419,7 @@
24092419
}
24102420

24112421
function dragStart (event) {
2412-
var dragEvent = new InteractEvent(downEvent, 'drag', 'start');
2422+
var dragEvent = new InteractEvent(event, 'drag', 'start');
24132423

24142424
dragging = true;
24152425

@@ -2420,16 +2430,11 @@
24202430
activeDrops.elements = [];
24212431
activeDrops.rects = [];
24222432

2423-
prevEvent = dragEvent;
2424-
24252433
if (!dynamicDrop) {
24262434
setActiveDrops(target._element);
24272435
}
24282436

2429-
// set snapping for the next move event
2430-
if (target.options.snapEnabled && !target.options.snap.endOnly) {
2431-
setSnapping(event);
2432-
}
2437+
return dragEvent;
24332438
}
24342439

24352440
function dragMove (event) {
@@ -2459,23 +2464,18 @@
24592464
prevDropTarget = dropTarget;
24602465
prevDropElement = dropElement;
24612466

2462-
prevEvent = dragEvent;
2467+
return dragEvent;
24632468
}
24642469

24652470
function resizeStart (event) {
2466-
var resizeEvent = new InteractEvent(downEvent, 'resize', 'start');
2471+
var resizeEvent = new InteractEvent(event, 'resize', 'start');
24672472

24682473
target.fire(resizeEvent);
24692474

24702475
target.fire(resizeEvent);
24712476
resizing = true;
24722477

2473-
prevEvent = resizeEvent;
2474-
2475-
// set snapping for the next move event
2476-
if (target.options.snapEnabled && !target.options.snap.endOnly) {
2477-
setSnapping(event);
2478-
}
2478+
return resizeEvent;
24792479
}
24802480

24812481
function resizeMove (event) {
@@ -2486,11 +2486,11 @@
24862486
resizeEvent = new InteractEvent(event, 'resize', 'move');
24872487
target.fire(resizeEvent);
24882488

2489-
prevEvent = resizeEvent;
2489+
return resizeEvent;
24902490
}
24912491

24922492
function gestureStart (event) {
2493-
var gestureEvent = new InteractEvent(downEvent, 'gesture', 'start');
2493+
var gestureEvent = new InteractEvent(event, 'gesture', 'start');
24942494

24952495
gestureEvent.ds = 0;
24962496

@@ -2502,12 +2502,7 @@
25022502

25032503
target.fire(gestureEvent);
25042504

2505-
prevEvent = gestureEvent;
2506-
2507-
// set snapping for the next move event
2508-
if (target.options.snapEnabled && !target.options.snap.endOnly) {
2509-
setSnapping(event);
2510-
}
2505+
return gestureEvent;
25112506
}
25122507

25132508
function gestureMove (event) {
@@ -2524,8 +2519,6 @@
25242519

25252520
target.fire(gestureEvent);
25262521

2527-
prevEvent = gestureEvent;
2528-
25292522
gesture.prevAngle = gestureEvent.angle;
25302523
gesture.prevDistance = gestureEvent.distance;
25312524

@@ -2536,6 +2529,8 @@
25362529

25372530
gesture.scale = gestureEvent.scale;
25382531
}
2532+
2533+
return gestureEvent;
25392534
}
25402535

25412536
function validateSelector (event, matches) {

0 commit comments

Comments
 (0)