With this PR, no newlines in between variant constructors. This makes the implementation simpler since I don't need to hack around node's location.

Personally, I prefer the formatting this way too. What do you think? @cknitt @zth @nojaf

Fine for me!

This is great! 🎉

Ok, I meant the new formatting of doc comments before variants is great.

Regarding the newlines, it would be nice if this was still possible:

type x =
  // first group
  | A
  | B
  | C

  // second group
  | D
  | E
  | F

Can't you just put an empty comment line where you want the break?

@shulhi, this is better! I wasn't a fan of adjusting the ranges in the parser to satisfy the format. It felt wrong.

This will reformat it to

type x =
  // first group
  | A
  | B
  | C
  // second group
  | D
  | E
  | F

I can still investigate this if we want to preserve the previous behavior. I actually like it without the newline.

The challenge with preserving the previous behavior has to do with how we treat comments and doc comments (comment table and attribute). If we compare the location for the comment for the above example, first group is attached to line 3, while it would be at line 2 for doc comment. We would have to adjust the ranges to make it print the same way for both - which felt like a hack.

Ok, that sounds quite hacky indeed.
I guess I can live with no newlines in that case. 🙂

@shulhi, this is better! I wasn't a fan of adjusting the ranges in the parser to satisfy the format. It felt wrong.