Fixed unit tests

frankebersoll · frankebersoll · commit 347606fac8e6 · 2016-02-18T23:48:38.000+01:00
diff --git a/src/storage/InMemoryStorage.ts b/src/storage/InMemoryStorage.ts
@@ -4,7 +4,7 @@ import { IStorageItem } from './IStorageItem';
 export class InMemoryStorage implements IStorage {
   private maxItems: number;
   private items: IStorageItem[] = [];
-  private lastTimestamp: number;
+  private lastTimestamp: number = 0;
 
   constructor(maxItems: number) {
     this.maxItems = maxItems;
@@ -27,7 +27,7 @@ export class InMemoryStorage implements IStorage {
     return item.timestamp;
   }
 
-  public get(limit: number = 1): IStorageItem[] {
+  public get(limit?: number): IStorageItem[] {
     return this.items.slice(0, limit);
   }
 
diff --git a/src/storage/KeyValueStorageBase.ts b/src/storage/KeyValueStorageBase.ts
@@ -3,8 +3,8 @@ import { IStorageItem } from './IStorageItem';
 
 export abstract class KeyValueStorageBase implements IStorage {
   private maxItems: number;
-  private items: number[] = [];
-  private lastTimestamp: number;
+  private items: number[];
+  private lastTimestamp: number = 0;
 
   constructor(maxItems) {
     this.maxItems = maxItems;
@@ -35,7 +35,7 @@ export abstract class KeyValueStorageBase implements IStorage {
     return timestamp;
   }
 
-  get(limit: number = 1): IStorageItem[] {
+  get(limit?: number): IStorageItem[] {
     this.ensureIndex();
 
     return this.items.slice(0, limit)
diff --git a/src/storage/Storage-spec.ts b/src/storage/Storage-spec.ts
@@ -11,12 +11,12 @@ import * as mockFs from 'mock-fs';
 let mockedFs;
 
 let nodeFileStorageFactory = (maxItems?) => {
-  return new NodeFileStorage('./fileStorage', maxItems, mockedFs);
+  return new NodeFileStorage('test', './fileStorage', 'ex-', maxItems, mockedFs);
 };
 
 let nodeFileStorageInitializer = () => {
   mockedFs = mockFs.fs({
-    'fileStorage': {}
+    'fileStorage': {},
   });
 };
 
@@ -26,7 +26,7 @@ describeStorage('NodeFileStorage',
   true
 );
 
-describeStorage('InMemoryStorage', (maxItems?) => {
+describeStorage('InMemoryStorage', (maxItems = 250) => {
   return new InMemoryStorage(maxItems);
 });
 

Original file line number	Diff line number	Diff line change
`@@ -4,7 +4,7 @@ import { IStorageItem } from './IStorageItem';`
`4`	`4`	`export class InMemoryStorage implements IStorage {`
`5`	`5`	`private maxItems: number;`
`6`	`6`	`private items: IStorageItem[] = [];`
`7`		`- private lastTimestamp: number;`
	`7`	`+ private lastTimestamp: number = 0;`
`8`	`8`
`9`	`9`	`constructor(maxItems: number) {`
`10`	`10`	`this.maxItems = maxItems;`
`@@ -27,7 +27,7 @@ export class InMemoryStorage implements IStorage {`
`27`	`27`	`return item.timestamp;`
`28`	`28`	`}`
`29`	`29`
`30`		`- public get(limit: number = 1): IStorageItem[] {`
	`30`	`+ public get(limit?: number): IStorageItem[] {`
`31`	`31`	`return this.items.slice(0, limit);`
`32`	`32`	`}`
`33`	`33`