BUG27277937: Fix confusing error message when using an unsupported collation

nmariz · nmariz · commit 67f9ebc2f33f · 2018-06-08T19:50:40.000+01:00
When using an unsupported collation an exception is raised with a confusing
error message.

A test was added for regression.
diff --git a/lib/mysql/connector/constants.py b/lib/mysql/connector/constants.py
@@ -699,8 +699,8 @@ def get_charset_info(cls, charset=None, collation=None):
                     continue
                 if info[0] == charset and info[1] == collation:
                     return (cid, info[0], info[1])
-            raise ProgrammingError("Character set '{0}' unknown.".format(
-                charset))
+            _ = cls.get_default_collation(charset)
+            raise ProgrammingError("Collation '{0}' unknown.".format(collation))
 
     @classmethod
     def get_supported(cls):
diff --git a/tests/test_bugs.py b/tests/test_bugs.py
@@ -5275,3 +5275,26 @@ def test_retrieve_stored_time_types(self):
         expected_type = timedelta
         self.run_test_retrieve_stored_type(stm, test_values, expected_values,
                                            column, expected_type)
+
+
+class BugOra27277937(tests.MySQLConnectorTests):
+    """BUG#27277937: CONFUSING ERROR MESSAGE WHEN SPECIFYING UNSUPPORTED
+    COLLATION
+    """
+    def setUp(self):
+        pass
+
+    def test_invalid_collation(self):
+        config = tests.get_mysql_config()
+        config["charset"] = "utf8"
+        config["collation"] = "foobar"
+        self.cnx = connection.MySQLConnection()
+        try:
+            self.cnx.connect(**config)
+        except errors.ProgrammingError as err:
+            self.assertEqual(err.msg, "Collation 'foobar' unknown.")
+        else:
+            self.fail("A ProgrammingError was expected")
+
+    def tearDown(self):
+        pass
