schema: remove custom lypy_node_fullname C function

rjarry · rjarry · commit ca2e3b3924dc · 2020-06-30T13:11:21.000+02:00
No need for that much performance here. Do it in python.

Signed-off-by: Robin Jarry &lt;robin@jarry.cc&gt;
diff --git a/cffi/cdefs.h b/cffi/cdefs.h
@@ -446,7 +446,6 @@ int lyd_validate(struct lyd_node **, int, void *);
 void free(void *);
 
 /* extra functions */
-char *lypy_node_fullname(const struct lys_node *);
 uint8_t lypy_module_implemented(const struct lys_module *);
 LY_ERR lypy_get_errno(void);
 void lypy_set_errno(LY_ERR);
diff --git a/cffi/source.c b/cffi/source.c
@@ -5,21 +5,6 @@
 
 #include <libyang/libyang.h>
 
-static char *lypy_node_fullname(const struct lys_node *node)
-{
-	const struct lys_module *module;
-	char *fullname = NULL;
-
-	module = lys_node_module(node);
-	if (!module)
-		return NULL;
-
-	if (asprintf(&fullname, "%s:%s", module->name, node->name) < 0)
-		return NULL;
-
-	return fullname;
-}
-
 static LY_ERR lypy_get_errno(void)
 {
 	return ly_errno;
diff --git a/libyang/schema.py b/libyang/schema.py
@@ -640,11 +640,7 @@ def name(self):
         return c2str(self._node.name)
 
     def fullname(self):
-        try:
-            s = lib.lypy_node_fullname(self._node)
-            return c2str(s)
-        finally:
-            lib.free(s)
+        return '%s:%s' % (self.module().name(), self.name())
 
     def description(self):
         return c2str(self._node.dsc)
