Escape tag values that ends with backslash (influxdata#537)

vaniakov · xginn8 · commit 6b5db784dcb3 · 2017-12-11T08:40:18.000-05:00
* FAM-1163 escape tag values that ends with backslash

* Add tests for _escape_tag_value func

* Remove print statement
diff --git a/influxdb/line_protocol.py b/influxdb/line_protocol.py
@@ -57,6 +57,13 @@ def _escape_tag(tag):
     )
 
 
+def _escape_tag_value(value):
+    ret = _escape_tag(value)
+    if ret.endswith('\\'):
+        ret += ' '
+    return ret
+
+
 def quote_ident(value):
     """Indent the quotes."""
     return "\"{}\"".format(value
@@ -135,7 +142,7 @@ def make_lines(data, precision=None):
         # tags should be sorted client-side to take load off server
         for tag_key, tag_value in sorted(iteritems(tags)):
             key = _escape_tag(tag_key)
-            value = _escape_tag(tag_value)
+            value = _escape_tag_value(tag_value)
 
             if key != '' and value != '':
                 key_values.append(key + "=" + value)
diff --git a/influxdb/tests/test_line_protocol.py b/influxdb/tests/test_line_protocol.py
@@ -22,6 +22,7 @@ def test_make_lines(self):
             "tags": {
                 "empty_tag": "",
                 "none_tag": None,
+                "backslash_tag": "C:\\",
                 "integer_tag": 2,
                 "string_tag": "hello"
             },
@@ -41,7 +42,7 @@ def test_make_lines(self):
 
         self.assertEqual(
             line_protocol.make_lines(data),
-            'test,integer_tag=2,string_tag=hello '
+            'test,backslash_tag=C:\\\\ ,integer_tag=2,string_tag=hello '
             'bool_val=True,float_val=1.1,int_val=1i,string_val="hello!"\n'
         )
 
