fix(debugger): enhance error handling in DAPClient and simplify port allocation for new testrun sessions

d-biehl · d-biehl · commit 43f242d61dc0 · 2025-07-31T00:32:33.000+02:00
- every new test run gets it's own tcp port fixes: #474
diff --git a/packages/debugger/src/robotcode/debugger/launcher/client.py b/packages/debugger/src/robotcode/debugger/launcher/client.py
@@ -96,8 +96,10 @@ async def wait() -> None:
                     self._protocol.on_connection_lost.add(self.on_connection_lost)
                 except (asyncio.CancelledError, KeyboardInterrupt, SystemExit):
                     raise
-                except ConnectionError:
+                except (ConnectionError, OSError):
                     pass
+                except BaseException as e:
+                    raise DAPClientError(f"Failed to connect to {self.tcp_params.host}:{self.tcp_params.port}") from e
 
         if self._protocol is not None:
             raise DAPClientError("Client already connected.")
diff --git a/packages/debugger/src/robotcode/debugger/launcher/server.py b/packages/debugger/src/robotcode/debugger/launcher/server.py
@@ -136,7 +136,7 @@ async def _launch(
 
         connect_timeout = launcherTimeout or 10
 
-        port = find_free_port(DEBUGGER_DEFAULT_PORT)
+        port = find_free_port()
 
         debugger_script = ["-m", "robotcode.cli"] if self.debugger_script is None else [str(Path(self.debugger_script))]
 
@@ -254,6 +254,7 @@ async def _launch(
                 ),
                 return_type=RunInTerminalResponseBody,
             )
+            # time.sleep(1)  # Give some time for the terminal to start
         elif console is None or console == "internalConsole":
             run_env: Dict[str, Optional[str]] = dict(os.environ)
             run_env.update(env)
diff --git a/tests/robotcode/language_server/robotframework/parts/data/.robot.toml b/tests/robotcode/language_server/robotframework/parts/data/.robot.toml
@@ -1,7 +1,7 @@
 [extend-profiles.firefox]
 description = "The overridden firefox profile"
 extend-python-path = ["./python"]
-output-dir = "output"
+#output-dir = "output"
 
 [tool.robotcode-analyze.extend-modifiers]
 extend-warning = ["VariableNotFound"]
