From 7c04d02c8fe5c66a0d3f685229de20ec8273de81 Mon Sep 17 00:00:00 2001 From: Ed Manlove Date: Sun, 15 Jun 2025 12:50:31 -0400 Subject: [PATCH 01/21] Updating selenium and robotframework versions we test against --- .github/workflows/CI.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml index 41fa78502..77891d523 100644 --- a/.github/workflows/CI.yml +++ b/.github/workflows/CI.yml @@ -10,8 +10,8 @@ jobs: strategy: matrix: python-version: [3.8, 3.13.0] # pypy-3.9 - rf-version: [6.1.1, 7.1.1] - selenium-version: [4.24.0, 4.25.0, 4.26.1, 4.27.1] + rf-version: [6.1.1, 7.2.2 7.3] + selenium-version: [4.32.0 4.33.0] browser: [firefox, chrome, headlesschrome] #edge steps: From 42399b688969dfdec2051ab988172458ac93460d Mon Sep 17 00:00:00 2001 From: Ed Manlove Date: Sun, 15 Jun 2025 13:05:10 -0400 Subject: [PATCH 02/21] Fixed required version syntax --- .github/workflows/CI.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml index 77891d523..ac98f2065 100644 --- a/.github/workflows/CI.yml +++ b/.github/workflows/CI.yml @@ -10,8 +10,8 @@ jobs: strategy: matrix: python-version: [3.8, 3.13.0] # pypy-3.9 - rf-version: [6.1.1, 7.2.2 7.3] - selenium-version: [4.32.0 4.33.0] + rf-version: [6.1.1, 7.2.2, 7.3] + selenium-version: [4.32.0, 4.33.0] browser: [firefox, chrome, headlesschrome] #edge steps: From 0f550e035c172a732ab5f6106dac0f0b53defd06 Mon Sep 17 00:00:00 2001 From: Ed Manlove Date: Sun, 15 Jun 2025 14:11:31 -0400 Subject: [PATCH 03/21] Bump lower Python version tested to 3.9 --- .github/workflows/CI.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml index ac98f2065..a4e12bbc6 100644 --- a/.github/workflows/CI.yml +++ b/.github/workflows/CI.yml @@ -9,7 +9,7 @@ jobs: continue-on-error: true strategy: matrix: - python-version: [3.8, 3.13.0] # pypy-3.9 + python-version: [3.9, 3.13.0] # pypy-3.9 rf-version: [6.1.1, 7.2.2, 7.3] selenium-version: [4.32.0, 4.33.0] browser: [firefox, chrome, headlesschrome] #edge From 33135cf653db990ff7ed97d567c6a6e2d5b06fb2 Mon Sep 17 00:00:00 2001 From: Ed Manlove Date: Wed, 18 Jun 2025 06:17:38 -0400 Subject: [PATCH 04/21] Updated expected error messages on a couple tests --- atest/acceptance/keywords/expected_conditions.robot | 2 +- atest/acceptance/keywords/run_on_failure.robot | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/atest/acceptance/keywords/expected_conditions.robot b/atest/acceptance/keywords/expected_conditions.robot index 4fa40dbfe..0df219177 100644 --- a/atest/acceptance/keywords/expected_conditions.robot +++ b/atest/acceptance/keywords/expected_conditions.robot @@ -10,7 +10,7 @@ Wait For Expected Conditions One Argument Title Should Be Delayed Wait For Expected Condition Times out within set timeout - [Documentation] FAIL REGEXP: TimeoutException: Message: Expected Condition not met within set timeout of 0.3* + [Documentation] FAIL STARTS: TimeoutException: Message: Expected Condition not met within set timeout of 0.3 Title Should Be Original Click Element link=delayed change title Wait For Expected Condition title_is Delayed timeout=0.3 diff --git a/atest/acceptance/keywords/run_on_failure.robot b/atest/acceptance/keywords/run_on_failure.robot index 761d4feca..6843aaf86 100644 --- a/atest/acceptance/keywords/run_on_failure.robot +++ b/atest/acceptance/keywords/run_on_failure.robot @@ -67,7 +67,7 @@ Run on Failure Returns Previous Value Should Be Equal ${old} Log Title Run On Failure also fails - [Documentation] LOG 2.1 WARN Keyword 'Failure During Run On failure' could not be run on failure: Expected error. + [Documentation] LOG 2.1.2 WARN Keyword 'Failure During Run On failure' could not be run on failure: Expected error. Register Keyword to Run on Failure Failure During Run On failure Run Keyword And Expect Error ... ${FAILURE MESSAGE} From 38e784d7a2edaf9f65372d0290310500ae543e48 Mon Sep 17 00:00:00 2001 From: Ed Manlove Date: Wed, 18 Jun 2025 07:32:39 -0400 Subject: [PATCH 05/21] Trying out key value pairs on python version for more expressive matrix --- .github/workflows/CI.yml | 26 ++++++++++++++++---------- 1 file changed, 16 insertions(+), 10 deletions(-) diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml index a4e12bbc6..a33d175bd 100644 --- a/.github/workflows/CI.yml +++ b/.github/workflows/CI.yml @@ -9,17 +9,18 @@ jobs: continue-on-error: true strategy: matrix: - python-version: [3.9, 3.13.0] # pypy-3.9 + # python-version: [3.9, 3.13.0] # pypy-3.9 + python-version: [{earliest: 3.9}, {latest: 3.13.0}] # pypy-3.9 rf-version: [6.1.1, 7.2.2, 7.3] selenium-version: [4.32.0, 4.33.0] browser: [firefox, chrome, headlesschrome] #edge steps: - uses: actions/checkout@v4 - - name: Set up Python ${{ matrix.python-version }} with Robot Framework ${{ matrix.rf-version }} + - name: Set up Python ${{ matrix.python-version.* }} with Robot Framework ${{ matrix.rf-version }} uses: actions/setup-python@v5 with: - python-version: ${{ matrix.python-version }} + python-version: ${{ matrix.python-version.* }} - name: Setup Chrome uses: browser-actions/setup-chrome@latest with: @@ -41,12 +42,12 @@ jobs: export DISPLAY=:99.0 Xvfb -ac :99 -screen 0 1280x1024x16 > /dev/null 2>&1 & - name: Install dependencies - if: matrix.python-version != 'pypy-3.7' + if: matrix.python-version.* != 'pypy-3.7' run: | python -m pip install --upgrade pip pip install -r requirements-dev.txt - name: Install dependencies for pypy - if: matrix.python-version == 'pypy-3.9' + if: matrix.python-version.* == 'pypy-3.9' run: | python -m pip install --upgrade pip pip install -r requirements.txt @@ -64,19 +65,24 @@ jobs: echo "$SELENIUM_MANAGER_EXE" echo "WEBDRIVERPATH=$($SELENIUM_MANAGER_EXE --browser chrome --debug | awk '/INFO[[:space:]]Driver path:/ {print $NF;exit}')" >> "$GITHUB_ENV" echo "$WEBDRIVERPATH" - - name: Generate stub file for ${{ matrix.python-version }} - if: matrix.python-version != 'pypy-3.9' + - name: Generate stub file for ${{ matrix.python-version.* }} + if: matrix.python-version.* != 'pypy-3.9' run: | invoke gen-stub # Temporarily ignoring pypy execution - name: Run tests with headless Chrome and with PyPy - if: startsWith( matrix.python-version, 'pypy') == true + if: startsWith( matrix.python-version.*, 'pypy') == true run: | xvfb-run --auto-servernum python atest/run.py --nounit --zip headlesschrome - - name: Run tests with ${{ matrix.browser }} if CPython - if: startsWith( matrix.python-version, 'pypy') == false + # - name: Run tests with ${{ matrix.browser }} if CPython + # if: startsWith( matrix.python-version, 'pypy') == false + # run: | + # xvfb-run --auto-servernum python atest/run.py --zip ${{ matrix.browser }} + + - name: Run tests with latest python + if: matrix.python-version == ${{ matrix.python.version.latest }} run: | xvfb-run --auto-servernum python atest/run.py --zip ${{ matrix.browser }} From 3f135fb350b36bd4fe9f2a8f94323d347d787dbc Mon Sep 17 00:00:00 2001 From: Ed Manlove Date: Wed, 18 Jun 2025 07:47:56 -0400 Subject: [PATCH 06/21] Limit test matrix to latest python version and latest rf version Also reveted back from expressive matrix options as I need to learn how to use key-value pairs within gh actions. --- .github/workflows/CI.yml | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml index a33d175bd..c69baffd3 100644 --- a/.github/workflows/CI.yml +++ b/.github/workflows/CI.yml @@ -9,18 +9,18 @@ jobs: continue-on-error: true strategy: matrix: - # python-version: [3.9, 3.13.0] # pypy-3.9 - python-version: [{earliest: 3.9}, {latest: 3.13.0}] # pypy-3.9 - rf-version: [6.1.1, 7.2.2, 7.3] + python-version: [3.9, 3.13.0] # pypy-3.9 + # python-version: [{earliest: 3.9}, {latest: 3.13.0}] # pypy-3.9 + rf-version: [6.1.1, 7.2.2, 7.3.1] selenium-version: [4.32.0, 4.33.0] browser: [firefox, chrome, headlesschrome] #edge steps: - uses: actions/checkout@v4 - - name: Set up Python ${{ matrix.python-version.* }} with Robot Framework ${{ matrix.rf-version }} + - name: Set up Python ${{ matrix.python-version }} with Robot Framework ${{ matrix.rf-version }} uses: actions/setup-python@v5 with: - python-version: ${{ matrix.python-version.* }} + python-version: ${{ matrix.python-version }} - name: Setup Chrome uses: browser-actions/setup-chrome@latest with: @@ -42,12 +42,12 @@ jobs: export DISPLAY=:99.0 Xvfb -ac :99 -screen 0 1280x1024x16 > /dev/null 2>&1 & - name: Install dependencies - if: matrix.python-version.* != 'pypy-3.7' + if: matrix.python-version != 'pypy-3.7' run: | python -m pip install --upgrade pip pip install -r requirements-dev.txt - name: Install dependencies for pypy - if: matrix.python-version.* == 'pypy-3.9' + if: matrix.python-version == 'pypy-3.9' run: | python -m pip install --upgrade pip pip install -r requirements.txt @@ -65,14 +65,14 @@ jobs: echo "$SELENIUM_MANAGER_EXE" echo "WEBDRIVERPATH=$($SELENIUM_MANAGER_EXE --browser chrome --debug | awk '/INFO[[:space:]]Driver path:/ {print $NF;exit}')" >> "$GITHUB_ENV" echo "$WEBDRIVERPATH" - - name: Generate stub file for ${{ matrix.python-version.* }} - if: matrix.python-version.* != 'pypy-3.9' + - name: Generate stub file for ${{ matrix.python-version }} + if: matrix.python-version != 'pypy-3.9' run: | invoke gen-stub # Temporarily ignoring pypy execution - name: Run tests with headless Chrome and with PyPy - if: startsWith( matrix.python-version.*, 'pypy') == true + if: startsWith( matrix.python-version, 'pypy') == true run: | xvfb-run --auto-servernum python atest/run.py --nounit --zip headlesschrome @@ -81,8 +81,8 @@ jobs: # run: | # xvfb-run --auto-servernum python atest/run.py --zip ${{ matrix.browser }} - - name: Run tests with latest python - if: matrix.python-version == ${{ matrix.python.version.latest }} + - name: Run tests with latest python and latest robot framework + if: matrix.python-version == '3.13.0' && matrix.rf-version == '7.3.1' run: | xvfb-run --auto-servernum python atest/run.py --zip ${{ matrix.browser }} From b54e4bab7f5be8a240bbd7c5e962a3ccf7c72b93 Mon Sep 17 00:00:00 2001 From: Ed Manlove Date: Wed, 18 Jun 2025 08:27:23 -0400 Subject: [PATCH 07/21] Uniquely name the artifacts --- .github/workflows/CI.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml index c69baffd3..5f414184e 100644 --- a/.github/workflows/CI.yml +++ b/.github/workflows/CI.yml @@ -96,6 +96,6 @@ jobs: - uses: actions/upload-artifact@v4 if: failure() with: - name: SeleniumLibrary Test results + name: sl_$${{ matrix.python-version }}_$${{ matrix.rf-version }}_$${{ matrix.selenium-version }}_$${{ matrix.browser }} path: atest/zip_results overwrite: true \ No newline at end of file From 4f947454b113fdc89ff008192965f7f4fb35721e Mon Sep 17 00:00:00 2001 From: Ed Manlove Date: Wed, 18 Jun 2025 17:00:26 -0400 Subject: [PATCH 08/21] Try slight delay in mouse over test --- atest/acceptance/keywords/mouse.robot | 1 + 1 file changed, 1 insertion(+) diff --git a/atest/acceptance/keywords/mouse.robot b/atest/acceptance/keywords/mouse.robot index 2c25035e0..52b8ea1df 100644 --- a/atest/acceptance/keywords/mouse.robot +++ b/atest/acceptance/keywords/mouse.robot @@ -8,6 +8,7 @@ Resource ../resource.robot Mouse Over [Tags] Known Issue Safari Mouse Over el_for_mouseover + Sleep 0.1secs Textfield Value Should Be el_for_mouseover mouseover el_for_mouseover Run Keyword And Expect Error ... Element with locator 'not_there' not found. From 46351bf926c7b5a7fdc66dfd3917d7e97a228ef9 Mon Sep 17 00:00:00 2001 From: Ed Manlove Date: Wed, 18 Jun 2025 19:53:45 -0400 Subject: [PATCH 09/21] Try slight delay in mouse over error test --- atest/acceptance/keywords/mouse.robot | 1 + 1 file changed, 1 insertion(+) diff --git a/atest/acceptance/keywords/mouse.robot b/atest/acceptance/keywords/mouse.robot index 52b8ea1df..5aff5c109 100644 --- a/atest/acceptance/keywords/mouse.robot +++ b/atest/acceptance/keywords/mouse.robot @@ -17,6 +17,7 @@ Mouse Over Mouse Over Error [Tags] Known Issue Safari Mouse Over el_for_mouseover + Sleep 0.1secs Textfield Value Should Be el_for_mouseover mouseover el_for_mouseover Run Keyword And Expect Error ... Element with locator '鱼在天空中飞翔' not found. From 30df9442dcb2bec59f1a50343d0d6623bad1c1a1 Mon Sep 17 00:00:00 2001 From: Ed Manlove Date: Wed, 18 Jun 2025 20:38:08 -0400 Subject: [PATCH 10/21] Try slowing down tests a bit --- atest/acceptance/keywords/textfields.robot | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/atest/acceptance/keywords/textfields.robot b/atest/acceptance/keywords/textfields.robot index 1fa6f4522..a5c879874 100644 --- a/atest/acceptance/keywords/textfields.robot +++ b/atest/acceptance/keywords/textfields.robot @@ -1,5 +1,5 @@ *** Settings *** -Test Setup Go To Page "forms/prefilled_email_form.html" +Test Setup Text Fields Test Suite Setup Resource ../resource.robot Force Tags Known Issue Internet Explorer @@ -75,3 +75,8 @@ Press Key Attempt Clear Element Text On Non-Editable Field Run Keyword And Expect Error * Clear Element Text can_send_email + +*** Keywords *** +Text Fields Test Suite Setup + Go To Page "forms/prefilled_email_form.html" + Set Selenium Speed 0.1secs \ No newline at end of file From 6780fbb94676dbec13a2822a225dd67f07f3b3c5 Mon Sep 17 00:00:00 2001 From: Ed Manlove Date: Wed, 18 Jun 2025 20:59:27 -0400 Subject: [PATCH 11/21] Trying RF verion 7.2.2 --- .github/workflows/CI.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml index 5f414184e..318d65aee 100644 --- a/.github/workflows/CI.yml +++ b/.github/workflows/CI.yml @@ -82,7 +82,7 @@ jobs: # xvfb-run --auto-servernum python atest/run.py --zip ${{ matrix.browser }} - name: Run tests with latest python and latest robot framework - if: matrix.python-version == '3.13.0' && matrix.rf-version == '7.3.1' + if: matrix.python-version == '3.13.0' && matrix.rf-version == '7.2.2' run: | xvfb-run --auto-servernum python atest/run.py --zip ${{ matrix.browser }} From 86ac810bf81df0530bd4f05c8cd50546f9d779ee Mon Sep 17 00:00:00 2001 From: Ed Manlove Date: Wed, 18 Jun 2025 21:12:43 -0400 Subject: [PATCH 12/21] Put back in previous selenium versions --- .github/workflows/CI.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml index 318d65aee..b0a966083 100644 --- a/.github/workflows/CI.yml +++ b/.github/workflows/CI.yml @@ -12,7 +12,7 @@ jobs: python-version: [3.9, 3.13.0] # pypy-3.9 # python-version: [{earliest: 3.9}, {latest: 3.13.0}] # pypy-3.9 rf-version: [6.1.1, 7.2.2, 7.3.1] - selenium-version: [4.32.0, 4.33.0] + selenium-version: [4.28.1, 4.29.0, 4.30.0, 4.31.0, 4.32.0, 4.33.0] browser: [firefox, chrome, headlesschrome] #edge steps: From f493acb1248c25ccbf6a49effcf5206003887c51 Mon Sep 17 00:00:00 2001 From: Ed Manlove Date: Thu, 19 Jun 2025 09:05:48 -0400 Subject: [PATCH 13/21] Added install chromedriver along side of chrome --- .github/workflows/CI.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml index b0a966083..4e139279e 100644 --- a/.github/workflows/CI.yml +++ b/.github/workflows/CI.yml @@ -25,6 +25,8 @@ jobs: uses: browser-actions/setup-chrome@latest with: chrome-version: latest + install-dependencies: true + install-chromedriver: true id: setup-chrome - run: | echo Installed chromium version: ${{ steps.setup-chrome.outputs.chrome-version }} From 52faa8612baf8fc6b6aa8e50ec36f7bfd116b5c7 Mon Sep 17 00:00:00 2001 From: Ed Manlove Date: Thu, 19 Jun 2025 09:22:13 -0400 Subject: [PATCH 14/21] Trying Chrome version 138 Also reduce test matrix for now and set setup-chrome action to v1 (as compared to @latest) --- .github/workflows/CI.yml | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml index 4e139279e..7f0d70143 100644 --- a/.github/workflows/CI.yml +++ b/.github/workflows/CI.yml @@ -9,11 +9,11 @@ jobs: continue-on-error: true strategy: matrix: - python-version: [3.9, 3.13.0] # pypy-3.9 + python-version: [3.13.0] # 3.9 pypy-3.9 # python-version: [{earliest: 3.9}, {latest: 3.13.0}] # pypy-3.9 - rf-version: [6.1.1, 7.2.2, 7.3.1] + rf-version: [7.2.2] # 6.1.1, 7.3.1 selenium-version: [4.28.1, 4.29.0, 4.30.0, 4.31.0, 4.32.0, 4.33.0] - browser: [firefox, chrome, headlesschrome] #edge + browser: [chrome] # firefox, chrome, headlesschrome, edge steps: - uses: actions/checkout@v4 @@ -22,9 +22,9 @@ jobs: with: python-version: ${{ matrix.python-version }} - name: Setup Chrome - uses: browser-actions/setup-chrome@latest + uses: browser-actions/setup-chrome@v1 with: - chrome-version: latest + chrome-version: 138 install-dependencies: true install-chromedriver: true id: setup-chrome From db74c43c500b04f03c9c7063fcc985aede4e5690 Mon Sep 17 00:00:00 2001 From: Ed Manlove Date: Thu, 19 Jun 2025 09:33:14 -0400 Subject: [PATCH 15/21] Trying chrome version 137 .. Looks like the system has Chrome 1.37 already installed. This will setup chrome 137 somewhere but more importantly add the driver. Realizing I may need to rework how we setup the machine .. --- .github/workflows/CI.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml index 7f0d70143..9d59ac27f 100644 --- a/.github/workflows/CI.yml +++ b/.github/workflows/CI.yml @@ -24,7 +24,7 @@ jobs: - name: Setup Chrome uses: browser-actions/setup-chrome@v1 with: - chrome-version: 138 + chrome-version: 137 install-dependencies: true install-chromedriver: true id: setup-chrome From eeec4b5f03a3986bced4af2d17d04c4acaa76f90 Mon Sep 17 00:00:00 2001 From: Ed Manlove Date: Sun, 3 Aug 2025 09:02:23 -0400 Subject: [PATCH 16/21] Turn off Chrome password leak detector --- atest/acceptance/keywords/textfields.robot | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/atest/acceptance/keywords/textfields.robot b/atest/acceptance/keywords/textfields.robot index a5c879874..6c3a41a3e 100644 --- a/atest/acceptance/keywords/textfields.robot +++ b/atest/acceptance/keywords/textfields.robot @@ -1,5 +1,6 @@ *** Settings *** -Test Setup Text Fields Test Suite Setup +Suite Setup Open Browser To Start Page Disabling Chrome Leaked Password Detection +Test Setup Go To Page "forms/prefilled_email_form.html" Resource ../resource.robot Force Tags Known Issue Internet Explorer @@ -77,6 +78,8 @@ Attempt Clear Element Text On Non-Editable Field Run Keyword And Expect Error * Clear Element Text can_send_email *** Keywords *** -Text Fields Test Suite Setup - Go To Page "forms/prefilled_email_form.html" - Set Selenium Speed 0.1secs \ No newline at end of file + +Open Browser To Start Page Disabling Chrome Leaked Password Detection + [Arguments] ${alias}=${None} + Open Browser ${FRONT PAGE} ${BROWSER} remote_url=${REMOTE_URL} + ... options=add_experimental_option("prefs", {"profile.password_manager_leak_detection": False}) alias=${alias} \ No newline at end of file From 8c9307b35cba6f9c0808b0c4f5599ac72c3de3f0 Mon Sep 17 00:00:00 2001 From: Ed Manlove Date: Sun, 3 Aug 2025 09:02:55 -0400 Subject: [PATCH 17/21] Tweak some timing on the alert tests --- atest/acceptance/keywords/alerts.robot | 1 + 1 file changed, 1 insertion(+) diff --git a/atest/acceptance/keywords/alerts.robot b/atest/acceptance/keywords/alerts.robot index bd6f0ecaf..01c6c9bdf 100644 --- a/atest/acceptance/keywords/alerts.robot +++ b/atest/acceptance/keywords/alerts.robot @@ -43,6 +43,7 @@ Handle Alert returns message Handle Alert with custom timeout Click Button Slow alert + Sleep 0.1s Handle Alert timeout=1s Click Button Slow alert Run Keyword And Expect Error From a8468c2579b5d5fc292e0e9c011a0d8b4bf876e3 Mon Sep 17 00:00:00 2001 From: Ed Manlove Date: Sun, 3 Aug 2025 09:42:05 -0400 Subject: [PATCH 18/21] Trying to get v138 chromedriver .. --- .github/workflows/CI.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml index 9d59ac27f..7f0d70143 100644 --- a/.github/workflows/CI.yml +++ b/.github/workflows/CI.yml @@ -24,7 +24,7 @@ jobs: - name: Setup Chrome uses: browser-actions/setup-chrome@v1 with: - chrome-version: 137 + chrome-version: 138 install-dependencies: true install-chromedriver: true id: setup-chrome From 467edb7b4041c5e9e3bf2bf4ddf7dbd96968a8d0 Mon Sep 17 00:00:00 2001 From: Ed Manlove Date: Sun, 3 Aug 2025 10:56:52 -0400 Subject: [PATCH 19/21] Expanding out the version text matrix verifying we are still good across many versions --- .github/workflows/CI.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml index 7f0d70143..df25eef2e 100644 --- a/.github/workflows/CI.yml +++ b/.github/workflows/CI.yml @@ -9,9 +9,9 @@ jobs: continue-on-error: true strategy: matrix: - python-version: [3.13.0] # 3.9 pypy-3.9 + python-version: [3.9.23, 3.13.5] # pypy-3.9 # python-version: [{earliest: 3.9}, {latest: 3.13.0}] # pypy-3.9 - rf-version: [7.2.2] # 6.1.1, 7.3.1 + rf-version: [6.1.1, 7.3.2] selenium-version: [4.28.1, 4.29.0, 4.30.0, 4.31.0, 4.32.0, 4.33.0] browser: [chrome] # firefox, chrome, headlesschrome, edge From b1dd105dbefc34bf3afdd5494056ea6d66c288ec Mon Sep 17 00:00:00 2001 From: Ed Manlove Date: Sun, 3 Aug 2025 11:16:58 -0400 Subject: [PATCH 20/21] Add latest selenium version 4.34.2 into test matrix --- .github/workflows/CI.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml index df25eef2e..c7ea56b17 100644 --- a/.github/workflows/CI.yml +++ b/.github/workflows/CI.yml @@ -12,7 +12,7 @@ jobs: python-version: [3.9.23, 3.13.5] # pypy-3.9 # python-version: [{earliest: 3.9}, {latest: 3.13.0}] # pypy-3.9 rf-version: [6.1.1, 7.3.2] - selenium-version: [4.28.1, 4.29.0, 4.30.0, 4.31.0, 4.32.0, 4.33.0] + selenium-version: [4.28.1, 4.29.0, 4.30.0, 4.31.0, 4.32.0, 4.33.0, 4.34.2] browser: [chrome] # firefox, chrome, headlesschrome, edge steps: From 573b36dfd1820fe6c365685240962477369948da Mon Sep 17 00:00:00 2001 From: Ed Manlove Date: Sun, 3 Aug 2025 14:32:04 -0400 Subject: [PATCH 21/21] Removed sleep and extended expected timeout. Previously the timeout was 1 sec and the alert was delayed 500ms. With a normal execution it seems that that 500ms diference is just not long enough to reasonably expect the alert to appear. In reviewing this test it was shown any delay was useful and the needed time for an alert to triggered and then recognized would need more than 500ms. --- atest/acceptance/keywords/alerts.robot | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/atest/acceptance/keywords/alerts.robot b/atest/acceptance/keywords/alerts.robot index 01c6c9bdf..fb18fdee5 100644 --- a/atest/acceptance/keywords/alerts.robot +++ b/atest/acceptance/keywords/alerts.robot @@ -43,8 +43,7 @@ Handle Alert returns message Handle Alert with custom timeout Click Button Slow alert - Sleep 0.1s - Handle Alert timeout=1s + Handle Alert timeout=2s Click Button Slow alert Run Keyword And Expect Error ... Alert not found in 1 millisecond.