Add iframe support #71
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ame>, using _element_find(). Added fix for _page_contains which will search both <frame> and <iframe> elements. But this fix for _page_contains needs a test first which is why the fix is currently commented out.
…rames and iframes. Currently iframe is failing as expected since patch has not been applied. Added test demonstrating how with the removal of the 'frame' tag from element searches could result in a "NoSuchFrameException" error if multiple elements have the same name attribute. Also demonstrated is how one can use xpath to search for either frame or iframe or both in such a case as a work around.
…rch both <frame> and <iframe> elements.
This was referenced Jun 30, 2012
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added iframe support by removing strict filtering for only elements.