Handle libraries with attrs having invalid __getattr__.

pekkaklarck · pekkaklarck · commit 2e10fb9ce1bf · 2023-11-16T18:31:43.000+02:00
This fixes a regression in RF 7.0a1 reported with SSHLibrary. It has
some kind of a config object with `__getattr__` that can raise other
exceptions than AttributeError. These exceptions go through when we use
`hasattr(candidate, 'robot_name')` and need to be handled in our code.
I consider SSHLibrary being buggy, but because it worked earlier
this can be consired a regression.
diff --git a/atest/robot/test_libraries/auto_keywords_off.robot b/atest/robot/test_libraries/auto_keywords_off.robot
@@ -14,3 +14,6 @@ Private Method Is Not Recognized As Keyword
 
 Private Decorated Method Is Recognized As Keyword
     Check Test Case    ${TESTNAME}
+
+Invalid __getattr__ is handled
+    Check Test Case    ${TESTNAME}
diff --git a/atest/testdata/test_libraries/ClassWithAutoKeywordsOff.py b/atest/testdata/test_libraries/ClassWithAutoKeywordsOff.py
@@ -1,6 +1,14 @@
 from robot.api.deco import keyword
 
 
+class InvalidGetattr:
+
+    def __getattr__(self, item):
+        if item == 'robot_name':
+            raise ValueError('This goes through getattr() and hasattr().')
+        raise AttributeError
+
+
 class ClassWithAutoKeywordsOff:
     ROBOT_AUTO_KEYWORDS = False
 
@@ -17,3 +25,5 @@ def _private_method_is_not_keyword(self):
     @keyword
     def _private_decorated_method_is_keyword(self):
         print('Decorated private methods are keywords.')
+
+    invalid_getattr = InvalidGetattr()
diff --git a/atest/testdata/test_libraries/auto_keywords_off.robot b/atest/testdata/test_libraries/auto_keywords_off.robot
@@ -18,3 +18,7 @@ Private Method Is Not Recognized As Keyword
 Private Decorated Method Is Recognized As Keyword
     Private Decorated Method Is Keyword
     Private Decorated Method In Module Is Keyword
+
+Invalid __getattr__ is handled
+    [Documentation]  FAIL  No keyword with name 'Invalid Getattr' found.
+    Invalid Getattr
diff --git a/src/robot/running/testlibraries.py b/src/robot/running/testlibraries.py
@@ -257,7 +257,10 @@ def has_robot_name(name):
             candidate = inspect.getattr_static(libcode, name)
             if isinstance(candidate, (classmethod, staticmethod)):
                 candidate = candidate.__func__
-            return hasattr(candidate, 'robot_name')
+            try:
+                return hasattr(candidate, 'robot_name')
+            except Exception:
+                return False
 
         auto_keywords = getattr(libcode, 'ROBOT_AUTO_KEYWORDS', True)
         if auto_keywords:
