Always verify message with Check Body Item Data

pekkaklarck · pekkaklarck · commit bf7bd995db96 · 2024-12-14T14:25:03.000+02:00
diff --git a/atest/resources/atest_resource.robot b/atest/resources/atest_resource.robot
@@ -114,8 +114,8 @@ Check Test Tags
     RETURN    ${tc}
 
 Check Body Item Data
-    [Arguments]    ${item}    ${type}=KEYWORD    ${status}=PASS    ${children}=-1    &{others}
-    FOR    ${key}    ${expected}    IN    type=${type}    status=${status}    type=${type}    &{others}
+    [Arguments]    ${item}    ${type}=KEYWORD    ${status}=PASS    ${message}=    ${children}=-1    &{others}
+    FOR    ${key}    ${expected}    IN    type=${type}    status=${status}    type=${type}    message=${message}    &{others}
         IF    $key == 'status' and $type == 'MESSAGE'    CONTINUE
         VAR    ${actual}    ${item.${key}}
         IF    isinstance($actual, collections.abc.Iterable) and not isinstance($actual, str)
diff --git a/atest/robot/running/group/group.robot b/atest/robot/running/group/group.robot
@@ -14,8 +14,8 @@ Basics
 
 Failing
     ${tc}=    Check Test Case    ${TESTNAME}
-    Check Body Item Data    ${tc[0]}       type=GROUP        name=Fails        children=2    status=FAIL
-    Check Body Item Data    ${tc[0, 0]}    type=KEYWORD      name=Fail         children=1    status=FAIL
+    Check Body Item Data    ${tc[0]}       type=GROUP        name=Fails        children=2    status=FAIL    message=Failing inside GROUP!
+    Check Body Item Data    ${tc[0, 0]}    type=KEYWORD      name=Fail         children=1    status=FAIL    message=Failing inside GROUP!
     Check Body Item Data    ${tc[0, 1]}    type=KEYWORD      name=Fail         children=0    status=NOT RUN
     Check Body Item Data    ${tc[1]}       type=GROUP        name=Not run      children=1    status=NOT RUN
     Check Body Item Data    ${tc[1, 0]}    type=KEYWORD      name=Fail         children=0    status=NOT RUN
diff --git a/atest/robot/running/group/invalid_group.robot b/atest/robot/running/group/invalid_group.robot
@@ -36,7 +36,7 @@ Non-existing variable in name
 Invalid data is not reported after failures
     ${tc}    Check Test Case    ${TESTNAME}
     Length Should Be        ${tc.body}    4
-    Check Body Item Data    ${tc[0]}      KEYWORD    status=FAIL       children=1    name=Fail    args=Something bad happened!
+    Check Body Item Data    ${tc[0]}      KEYWORD    status=FAIL       children=1    name=Fail    args=Something bad happened!    message=Something bad happened!
     Check Body Item Data    ${tc[1]}      GROUP      status=NOT RUN    children=1    name=\${non_existing_non_executed_variable_is_ok}
     Check Body Item Data    ${tc[1, 0]}   KEYWORD    status=NOT RUN    children=0    name=Fail    args=Not run
     Check Body Item Data    ${tc[2]}      GROUP      status=NOT RUN    children=0    name=Empty non-executed GROUP is ok
