-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Add memoization to --dryrun #3241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I've never heard dry-run taking that much time but I believe it can happen with complex enough data. Not validating keywords that have already been validated sounds like a good idea, but I'm not sure how easy it would be. Some challenges listed below:
Problems above are likely solvable and prototyping this would be great. I personally won't have time for it in the foreseeable future, but perhaps you @myjniak could look at it yourself. Or perhaps @mkorpela would be interested because, AFAIK, pabot also uses dry-run internally and would benefit from speedups. |
Pabot internally hacks away most of the data in dryrun as pabot is only interested about the names of the test cases that will be executed. |
No updates since 2019 so this doesn't seem to be too critical. New issue can be opened, or this one reopened, later if needed. We'd most importantly needed a PR implementing this. |
In case when tests are getting pretty complicated, a test dryrun may take even several seconds.
When multiple tests of similar content are added, it can even exceed several minutes.
In my case, dry run check is performed on the same part of code lots of times.
If a keyword has already been verified, you can copy the results each time it's called again.
It would greatly improve dryrun performance.
A 7-minute dryrun added to attachments.
log.zip
The text was updated successfully, but these errors were encountered: