Fix analysis hints in flutter_html_svg

Sub6Resources · Sub6Resources · commit f7ad078722c9 · 2022-09-27T07:45:07.000-06:00
diff --git a/packages/flutter_html_svg/lib/flutter_html_svg.dart b/packages/flutter_html_svg/lib/flutter_html_svg.dart
@@ -42,7 +42,7 @@ CustomRender svgDataImageRender() =>
       final dataUri = _dataUriFormat.firstMatch(
           _src(context.tree.element?.attributes.cast() ?? <String, String>{})!);
       final data = dataUri?.namedGroup('data');
-      if (data == null) return Container(height: 0, width: 0);
+      if (data == null) return const SizedBox(height: 0, width: 0);
       return Builder(
           key: context.key,
           builder: (buildContext) {
@@ -74,7 +74,7 @@ CustomRender svgDataImageRender() =>
 CustomRender svgNetworkImageRender() =>
     CustomRender.widget(widget: (context, buildChildren) {
       if (context.tree.element?.attributes["src"] == null) {
-        return Container(height: 0, width: 0);
+        return const SizedBox(height: 0, width: 0);
       }
       return Builder(
           key: context.key,
@@ -104,7 +104,7 @@ CustomRender svgAssetImageRender() =>
     CustomRender.widget(widget: (context, buildChildren) {
       if (_src(context.tree.element?.attributes.cast() ?? <String, String>{}) ==
           null) {
-        return Container(height: 0, width: 0);
+        return const SizedBox(height: 0, width: 0);
       }
       final assetPath = _src(context.tree.element!.attributes.cast())!
           .replaceFirst('asset:', '');
@@ -148,7 +148,7 @@ CustomRenderMatcher svgDataUriMatcher(
 
 /// A CustomRenderMatcher for an <img> tag with an svg tag over the network
 CustomRenderMatcher svgNetworkSourceMatcher({
-  List<String> schemas: const ["https", "http"],
+  List<String> schemas = const ["https", "http"],
   List<String>? domains,
   String? extension = "svg",
 }) =>
@@ -178,7 +178,7 @@ CustomRenderMatcher svgAssetUriMatcher() => (context) =>
         .endsWith(".svg");
 
 final _dataUriFormat = RegExp(
-    "^(?<scheme>data):(?<mime>image\/[\\w\+\-\.]+)(?<encoding>;base64)?\,(?<data>.*)");
+    "^(?<scheme>data):(?<mime>image\\/[\\w\\+\\-\\.]+)(?<encoding>;base64)?\\,(?<data>.*)");
 
 String? _src(Map<String, String> attributes) {
   return attributes["src"];
diff --git a/packages/flutter_html_svg/pubspec.yaml b/packages/flutter_html_svg/pubspec.yaml
@@ -21,5 +21,6 @@ dev_dependencies:
   flutter_test:
     sdk: flutter
   flutter_lints: ^2.0.1
+  meta: ^1.8.0
 
 flutter:
diff --git a/packages/flutter_html_svg/test/svg_image_matcher_source_matcher_test.dart b/packages/flutter_html_svg/test/svg_image_matcher_source_matcher_test.dart
@@ -64,7 +64,7 @@ void main() {
 
 String _fakeElement(String? src) {
   return """
-      <img src="$src" />
+      <img alt='' src="$src" />
     """;
 }
 
@@ -83,7 +83,7 @@ void testImgSrcMatcher(
           customRenders: {
             matcher: CustomRender.widget(
               widget: (RenderContext context, _) {
-                return Text("Success");
+                return const Text("Success");
               },
             ),
           },
@@ -98,14 +98,14 @@ void testImgSrcMatcher(
 class TestApp extends StatelessWidget {
   final Widget body;
 
-  TestApp(this.body);
+  const TestApp(this.body, {Key? key}) : super(key: key);
 
   @override
   Widget build(BuildContext context) {
     return MaterialApp(
       home: Scaffold(
         body: body,
-        appBar: AppBar(title: Text('flutter_html')),
+        appBar: AppBar(title: const Text('flutter_html')),
       ),
     );
   }
