Change implementation to address lint errors

robtaussig · robtaussig · commit 99eac6f71c2e · 2018-05-25T20:53:29.000-04:00
diff --git a/src/algorithms/sorting/quick-sort/QuickSort.js b/src/algorithms/sorting/quick-sort/QuickSort.js
@@ -44,51 +44,50 @@ export default class QuickSort extends Sort {
 
   /* Sorting in place avoids unnecessary use of additional memory, but modifies input array.
    *
-   * This process is difficult to describe, but much clearer with a visualization: 
+   * This process is difficult to describe, but much clearer with a visualization:
    * http://www.algomation.com/algorithm/quick-sort-visualization
    */
-  sortInPlace(array, low, high) {
-
+  sortInPlace(inputArray, inputLow, inputHigh) {
+    const array = inputLow === undefined ? [...inputArray] : inputArray;
     // Partition array segment and return index of last swap
-    const partition = (arr, l, h) => {
-      const swap = (a, left, right) => {
-        const tempVariable = a[left];
-        a[left] = a[right];
-        a[right] = tempVariable;
-      }
+    const partition = (l, h) => {
+      const swap = (left, right) => {
+        const tempVariable = array[left];
+        array[left] = array[right];
+        array[right] = tempVariable;
+      };
 
       const pivot = arr[h];
       let firstRunner = l - 1;
 
       for (let secondRunner = l; secondRunner < h; secondRunner += 1) {
-
-        if (arr[secondRunner] < pivot) {
+        if (array[secondRunner] < pivot) {
           firstRunner += 1;
-          swap(arr, firstRunner, secondRunner);
+          swap(firstRunner, secondRunner);
         }
       }
 
-      if (arr[firstRunner + 1] > pivot) {
-        swap(arr, firstRunner + 1, h);
+      if (array[firstRunner + 1] > pivot) {
+        swap(firstRunner + 1, h);
       }
 
       return firstRunner + 1;
     };
 
     /*
-     * While we can use a default parameter to set `low` to 0, we would still have to set `high`'s default within the function 
-     * as we don't have access to `array.length - 1` when declaring paramaters
+     * While we can use a default parameter to set `low` to 0, we would still have to set `high`'s
+     * default within the function as we don't have access to `array.length - 1` when declaring paramaters
      */
-    low = low === undefined ? 0 : low;
-    high = high === undefined ? array.length - 1 : high;
+    const low = inputLow === undefined ? 0 : inputLow;
+    const high = inputHigh === undefined ? array.length - 1 : inputHigh;
 
     // Base case is when low and high converge
     if (low < high) {
-      const partitionIndex = partition(array, low, high);
+      const partitionIndex = partition(low, high);
       /*
-       * `partition()` swaps elements of the array based on their comparison to the `hi` parameter, and then returns the index
-       * where swapping is no longer necessary, which can be best thought of as the pivot used to split an array in a
-       * non-in-place quicksort
+       * `partition()` swaps elements of the array based on their comparison to the `hi` parameter,
+       * and then returns the index where swapping is no longer necessary, which can be best thought 
+       * of as the pivot used to split an array in a non-in-place quicksort
        */
       this.sortInPlace(array, low, partitionIndex - 1);
       this.sortInPlace(array, partitionIndex + 1, high);
