From 010093910c02278dedec66d48c03f43a05439557 Mon Sep 17 00:00:00 2001 From: Rohan Bhaumik Date: Thu, 19 Dec 2024 16:46:26 +0530 Subject: [PATCH 1/3] reducing # of codecov uplaods --- .github/workflows/ci.yml | 36 ++++++++++++++++++------------------ 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index de00c20f..e20854cc 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -27,24 +27,24 @@ jobs: fail_ci_if_error: true token: ${{ secrets.CODECOV_TOKEN }} verbose: true - - name: Upload coverage to Codecov (env token) - uses: codecov/codecov-action@main - with: - fail_ci_if_error: true - verbose: true - env: - CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }} - - name: Upload coverage to Codecov (no token) - uses: codecov/codecov-action@main - with: - fail_ci_if_error: true - verbose: true - - name: Upload coverage to Codecov (oidc) - uses: codecov/codecov-action@main - with: - fail_ci_if_error: true - use_oidc: true - verbose: true + #- name: Upload coverage to Codecov (env token) + #uses: codecov/codecov-action@main + #with: + # fail_ci_if_error: true + #verbose: true + #env: + # CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }} + #- name: Upload coverage to Codecov (no token) + #uses: codecov/codecov-action@main + #with: + # fail_ci_if_error: true + #verbose: true + #- name: Upload coverage to Codecov (oidc) + # uses: codecov/codecov-action@main + #with: + # fail_ci_if_error: true + #use_oidc: true + #verbose: true #- name: Upload test results to Codecov # if: ${{ !cancelled() }} #uses: codecov/test-results-action@v1 From cb19885aa5a8f71b997dbce8396e687ec4514584 Mon Sep 17 00:00:00 2001 From: Rohan Bhaumik Date: Thu, 19 Dec 2024 16:48:38 +0530 Subject: [PATCH 2/3] resetting flake count --- app/test_calculator.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test_calculator.py b/app/test_calculator.py index 30102437..d6736b12 100644 --- a/app/test_calculator.py +++ b/app/test_calculator.py @@ -27,5 +27,5 @@ def test_divide(): assert Calculator.divide(1, 2) == 0.5 assert Calculator.divide(1.0, 2.0) == 0.5 assert Calculator.divide(0, 2.0) == 0 - # assert Calculator.divide(-4, 2.0) == -2.0 + assert Calculator.divide(-4, 2.0) == -2.0 assert Calculator.divide(2.0, 0.0) == 'Cannot divide by 0' \ No newline at end of file From cbd563dd9b0300f0fa57b36c0eb4a232205f6b76 Mon Sep 17 00:00:00 2001 From: Rohan Bhaumik Date: Thu, 19 Dec 2024 16:49:42 +0530 Subject: [PATCH 3/3] attempt 2 --- app/test_calculator.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test_calculator.py b/app/test_calculator.py index d6736b12..e9513f43 100644 --- a/app/test_calculator.py +++ b/app/test_calculator.py @@ -28,4 +28,4 @@ def test_divide(): assert Calculator.divide(1.0, 2.0) == 0.5 assert Calculator.divide(0, 2.0) == 0 assert Calculator.divide(-4, 2.0) == -2.0 - assert Calculator.divide(2.0, 0.0) == 'Cannot divide by 0' \ No newline at end of file + # assert Calculator.divide(2.0, 0.0) == 'Cannot divide by 0' \ No newline at end of file