Fix issue with creating hard links on Windows #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -261,7 +261,7 @@ | |||
| var onlink = function () { | |||
| if (win32) return next() // skip links on win for now before it can be tested | |||
| xfs.unlink(name, function () { | |||
| var srcpath = path.join(cwd, path.join('/', header.linkname)) | |||
| var srcpath = path.resolve(cwd, header.linkname) | |||
Check failure
Code scanning / CodeQL
Arbitrary file access during archive extraction ("Zip Slip")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes a change to the
exports.extractfunction in theindex.jsfile. The change modifies the way source paths are resolved for links. Instead of joining the current working directory (cwd) and the link name usingpath.join, the code now usespath.resolveto determine the source path. This change should provide a more accurate and reliable way to resolve paths.