Skip to content

Commit 773ccd7

Browse files
rohitpaulkrohitpaulk
committed
Fix user controller specs
1 parent e847d77 commit 773ccd7

File tree

5 files changed

+162
-117
lines changed

5 files changed

+162
-117
lines changed

‎spec/controllers/users_controller_spec.rb

Lines changed: 4 additions & 116 deletions
Original file line numberDiff line numberDiff line change
@@ -1,42 +1,14 @@
11
require 'spec_helper'
22

3-
RSpec.describe UsersController, type: :controller, skip: true do
3+
RSpec.describe UsersController, type: :controller do
44
let(:user) do
55
user = Fabricate.build(:user)
66
user.badges << Fabricate.build(:badge, badge_class_name: 'Octopussy')
77
user.save!
88
user
99
end
1010

11-
let(:github_response) do {
12-
'provider' => 'github',
13-
'uid' => 1_310_330,
14-
'info' => { 'nickname' => 'throwaway1',
15-
'email' => 'md@asdf.com',
16-
'name' => nil,
17-
'urls' => { 'GitHub' => 'https://github.com/throwaway1', 'Blog' => nil } },
18-
'credentials' => { 'token' => '59cdff603a4e70d47f0a28b5ccaa3935aaa790cf', 'expires' => false },
19-
'extra' => { 'raw_info' => { 'owned_private_repos' => 0,
20-
'type' => 'User',
21-
'avatar_url' => 'https://secure.gravatar.com/avatar/b08ed2199f8a88360c9679a57c4f9305?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png',
22-
'created_at' => '2012-01-06T20:49:02Z',
23-
'login' => 'throwaway1',
24-
'disk_usage' => 0,
25-
'plan' => { 'space' => 307_200,
26-
'private_repos' => 0,
27-
'name' => 'free',
28-
'collaborators' => 0 },
29-
'public_repos' => 0,
30-
'following' => 0,
31-
'public_gists' => 0,
32-
'followers' => 0,
33-
'gravatar_id' => 'b08ed2199f8a88360c9679a57c4f9305',
34-
'total_private_repos' => 0,
35-
'collaborators' => 0,
36-
'html_url' => 'https://github.com/throwaway1',
37-
'url' => 'https://api.github.com/users/throwaway1',
38-
'id' => 1_310_330,
39-
'private_gists' => 0 } } }.with_indifferent_access end
11+
let(:github_response) { JSON.parse(File.read('./spec/fixtures/oauth/github_response.json')).with_indifferent_access }
4012

4113
it 'should get user page by ignoring the case' do
4214
get :show, username: user.username.downcase
@@ -108,7 +80,6 @@
10880
it 'applies oauth information to user on creation' do
10981
session['oauth.data'] = github_response
11082
post :create, user: { location: 'SF' }
111-
# assigns[:user].thumbnail_url == 'https://secure.gravatar.com/avatar/b08ed2199f8a88360c9679a57c4f9305'
11283
assigns[:user].github == 'throwaway1'
11384
assigns[:user].github_token == '59cdff603a4e70d47f0a28b5ccaa3935aaa790cf'
11485
end
@@ -135,24 +106,7 @@
135106
end
136107

137108
describe 'linkedin' do
138-
let(:linkedin_response) do {
139-
'provider' => 'linkedin',
140-
'uid' => 'DlC5AmUPnM',
141-
'info' => { 'first_name' => 'Matthew',
142-
'last_name' => 'Deiters',
143-
'name' => 'Matthew Deiters',
144-
'headline' => '-',
145-
'image' => 'http://media.linkedin.com/mpr/mprx/0_gPLYkP6hYm6ap1Vcxq5TkrTSYulmpzUc0tA3krFxTW5YiluBAvztoKPlKGAlx-sRyKF8wBv2M2QD',
146-
'industry' => 'Computer Software',
147-
'urls' => { 'public_profile' => 'http://www.linkedin.com/in/matthewdeiters' } },
148-
'credentials' => { 'token' => 'acafe540-606a-4f73-aef7-f6eba276603', 'secret' => 'df7427be-3d93-4563-baef-d1d38826686' },
149-
'extra' => { 'raw_info' => { 'firstName' => 'Matthew',
150-
'headline' => '-',
151-
'id' => 'DlC5AmUPnM',
152-
'industry' => 'Computer Software',
153-
'lastName' => 'Deiters',
154-
'pictureUrl' => 'http://media.linkedin.com/mpr/mprx/0_gPLYkP6hYm6ap1Vcxq5TkrTSYulmpzUc0tA3krFxTW5YiluBAvztoKPlKGAlx-sRyKF8wBv2M2QD',
155-
'publicProfileUrl' => 'http://www.linkedin.com/in/matthewdeiters' } } }.with_indifferent_access end
109+
let(:linkedin_response) { JSON.parse(File.read('./spec/fixtures/oauth/linkedin_response.json')).with_indifferent_access }
156110

157111
it 'setups up new user and redirects to signup page' do
158112
session['oauth.data'] = linkedin_response
@@ -169,73 +123,7 @@
169123
end
170124

171125
describe 'twitter' do
172-
let(:twitter_response) do {
173-
'provider' => 'twitter',
174-
'uid' => '6271932',
175-
'info' => { 'nickname' => 'mdeiters',
176-
'name' => 'matthew deiters',
177-
'location' => 'San Francisco',
178-
'image' => 'http://a1.twimg.com/profile_images/1672080012/instagram_profile_normal.jpg',
179-
'description' => 'Dad. Amateur Foodie. Founder Extraordinaire of @coderwall',
180-
'urls' => { 'Website' => 'http://coderwall.com/mdeiters', 'Twitter' => 'http://twitter.com/mdeiters' } },
181-
'credentials' => { 'token' => '6271932-8erxrXfJykBNMrvsdCEq5WqKd6FIcO97L9BzvPq7',
182-
'secret' => '8fRS1ZARd6Wm53wvvDwHNrBmZcW0H2aSwmQjuOTHl' },
183-
'extra' => {
184-
'raw_info' => { 'lang' => 'en',
185-
'profile_background_image_url' => 'http://a2.twimg.com/profile_background_images/6771536/Fresh-Grass_1600.jpg',
186-
'protected' => false,
187-
'time_zone' => 'Pacific Time (US & Canada)',
188-
'created_at' => 'Wed May 23 21:14:29 +0000 2007',
189-
'profile_link_color' => '0084B4',
190-
'name' => 'matthew deiters',
191-
'listed_count' => 27,
192-
'contributors_enabled' => false,
193-
'followers_count' => 375,
194-
'profile_image_url' => 'http://a1.twimg.com/profile_images/1672080012/instagram_profile_normal.jpg',
195-
'utc_offset' => -28_800,
196-
'profile_background_color' => '9AE4E8',
197-
'description' => 'Dad. Amateur Foodie. Founder Extraordinaire of @coderwall',
198-
'statuses_count' => 720,
199-
'profile_background_tile' => false,
200-
'following' => false,
201-
'verified' => false,
202-
'profile_sidebar_fill_color' => 'DDFFCC',
203-
'status' => { 'in_reply_to_user_id' => 5_446_832,
204-
'favorited' => false, 'place' => nil,
205-
'created_at' => 'Sat Jan 07 01:57:54 +0000 2012',
206-
'retweet_count' => 0,
207-
'in_reply_to_screen_name' => 'chrislloyd',
208-
'in_reply_to_status_id_str' => '155460652457148416',
209-
'retweeted' => false,
210-
'in_reply_to_user_id_str' => '5446832',
211-
'geo' => nil,
212-
'in_reply_to_status_id' => 155_460_652_457_148_416,
213-
'id_str' => '155468169815932928',
214-
'contributors' => nil,
215-
'coordinates' => nil,
216-
'truncated' => false,
217-
'source' => "<a href=\"http://twitter.com/#!/download/iphone\" rel=\"nofollow\">Twitter for iPhone</a>",
218-
'id' => 155_468_169_815_932_928,
219-
'text' => '@minefold @chrislloyd FYI your losing seo juice with a blog sub domain' },
220-
'default_profile_image' => false,
221-
'friends_count' => 301,
222-
'location' => 'San Francisco',
223-
'screen_name' => 'mdeiters',
224-
'default_profile' => false,
225-
'profile_background_image_url_https' => 'https://si0.twimg.com/profile_background_images/6771536/Fresh-Grass_1600.jpg',
226-
'profile_sidebar_border_color' => 'BDDCAD',
227-
'id_str' => '6271932',
228-
'is_translator' => false,
229-
'geo_enabled' => true,
230-
'url' => 'http://coderwall.com/mdeiters',
231-
'profile_image_url_https' => 'https://si0.twimg.com/profile_images/1672080012/instagram_profile_normal.jpg',
232-
'profile_use_background_image' => true,
233-
'favourites_count' => 178,
234-
'id' => 6_271_932,
235-
'show_all_inline_media' => false,
236-
'follow_request_sent' => false,
237-
'notifications' => false,
238-
'profile_text_color' => '333333' } } }.with_indifferent_access end
126+
let(:twitter_response) { JSON.parse(File.read('./spec/fixtures/oauth/twitter_response.json')).with_indifferent_access }
239127

240128
it 'setups up new user and redirects to signup page' do
241129
session['oauth.data'] = twitter_response

‎spec/fixtures/oauth/github_response.json

Lines changed: 46 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,46 @@
1+
{
2+
"provider": "github",
3+
"uid": "1_310_330",
4+
"info": {
5+
"nickname": "throwaway1",
6+
"email": "md@asdf.com",
7+
"name": null,
8+
"urls": {
9+
"GitHub": "https://github.com/throwaway1",
10+
"Blog": null
11+
}
12+
},
13+
"credentials": {
14+
"token": "59cdff603a4e70d47f0a28b5ccaa3935aaa790cf",
15+
"expires": false
16+
},
17+
"extra": {
18+
"raw_info": {
19+
"owned_private_repos": 0,
20+
"type": "User",
21+
"avatar_url" : "https://secure.gravatar.com/avatar/b08ed2199f8a88360c9679a57c4f9305?d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png",
22+
"created_at" : "2012-01-06T20:49:02Z",
23+
"login" : "throwaway1",
24+
"disk_usage" : 0,
25+
"plan" : {
26+
"space" : "307_200",
27+
"private_repos" : 0,
28+
"name" : "free",
29+
"collaborators" : 0
30+
},
31+
"public_repos": 0,
32+
"following": 0,
33+
"public_gists": 0,
34+
"followers": 0,
35+
"gravatar_id": "b08ed2199f8a88360c9679a57c4f9305",
36+
"total_private_repos": 0,
37+
"collaborators": 0,
38+
"html_url": "https://github.com/throwaway1",
39+
"url": "https://api.github.com/users/throwaway1",
40+
"id": "1_310_330",
41+
"private_gists": 0
42+
}
43+
}
44+
}
45+
46+

‎spec/fixtures/oauth/linkedin_response.json

Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,30 @@
1+
{
2+
"provider":"linkedin",
3+
"uid":"DlC5AmUPnM",
4+
"info":{
5+
"first_name":"Matthew",
6+
"last_name":"Deiters",
7+
"name":"Matthew Deiters",
8+
"headline":"-",
9+
"image":"http://media.linkedin.com/mpr/mprx/0_gPLYkP6hYm6ap1Vcxq5TkrTSYulmpzUc0tA3krFxTW5YiluBAvztoKPlKGAlx-sRyKF8wBv2M2QD",
10+
"industry":"Computer Software",
11+
"urls":{
12+
"public_profile":"http://www.linkedin.com/in/matthewdeiters"
13+
}
14+
},
15+
"credentials":{
16+
"token":"acafe540-606a-4f73-aef7-f6eba276603",
17+
"secret":"df7427be-3d93-4563-baef-d1d38826686"
18+
},
19+
"extra":{
20+
"raw_info":{
21+
"firstName":"Matthew",
22+
"headline":"-",
23+
"id":"DlC5AmUPnM",
24+
"industry":"Computer Software",
25+
"lastName":"Deiters",
26+
"pictureUrl":"http://media.linkedin.com/mpr/mprx/0_gPLYkP6hYm6ap1Vcxq5TkrTSYulmpzUc0tA3krFxTW5YiluBAvztoKPlKGAlx-sRyKF8wBv2M2QD",
27+
"publicProfileUrl":"http://www.linkedin.com/in/matthewdeiters"
28+
}
29+
}
30+
}

‎spec/fixtures/oauth/twitter_response.json

Lines changed: 81 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,81 @@
1+
{
2+
"provider":"twitter",
3+
"uid":"6271932",
4+
"info":{
5+
"nickname":"mdeiters",
6+
"name":"matthew deiters",
7+
"location":"San Francisco",
8+
"image":"http://a1.twimg.com/profile_images/1672080012/instagram_profile_normal.jpg",
9+
"description":"Dad. Amateur Foodie. Founder Extraordinaire of @coderwall",
10+
"urls":{
11+
"Website":"http://coderwall.com/mdeiters",
12+
"Twitter":"http://twitter.com/mdeiters"
13+
}
14+
},
15+
"credentials":{
16+
"token":"6271932-8erxrXfJykBNMrvsdCEq5WqKd6FIcO97L9BzvPq7",
17+
"secret":"8fRS1ZARd6Wm53wvvDwHNrBmZcW0H2aSwmQjuOTHl"
18+
},
19+
"extra":{
20+
"raw_info":{
21+
"lang":"en",
22+
"profile_background_image_url":"http://a2.twimg.com/profile_background_images/6771536/Fresh-Grass_1600.jpg",
23+
"protected":false,
24+
"time_zone":"Pacific Time (US & Canada)",
25+
"created_at":"Wed May 23 21:14:29 +0000 2007",
26+
"profile_link_color":"0084B4",
27+
"name":"matthew deiters",
28+
"listed_count":27,
29+
"contributors_enabled":false,
30+
"followers_count":375,
31+
"profile_image_url":"http://a1.twimg.com/profile_images/1672080012/instagram_profile_normal.jpg",
32+
"utc_offset":-28800,
33+
"profile_background_color":"9AE4E8",
34+
"description":"Dad. Amateur Foodie. Founder Extraordinaire of @coderwall",
35+
"statuses_count":720,
36+
"profile_background_tile":false,
37+
"following":false,
38+
"verified":false,
39+
"profile_sidebar_fill_color":"DDFFCC",
40+
"status":{
41+
"in_reply_to_user_id":5446832,
42+
"favorited":false,
43+
"place":null,
44+
"created_at":"Sat Jan 07 01:57:54 +0000 2012",
45+
"retweet_count":0,
46+
"in_reply_to_screen_name":"chrislloyd",
47+
"in_reply_to_status_id_str":"155460652457148416",
48+
"retweeted":false,
49+
"in_reply_to_user_id_str":"5446832",
50+
"geo":null,
51+
"in_reply_to_status_id":155460652457148416,
52+
"id_str":"155468169815932928",
53+
"contributors":null,
54+
"coordinates":null,
55+
"truncated":false,
56+
"source":"<a href=\"http://twitter.com/#!/download/iphone\" rel=\"nofollow\">Twitter for iPhone</a>",
57+
"id":155468169815932928,
58+
"text":"@minefold @chrislloyd FYI your losing seo juice with a blog sub domain"
59+
},
60+
"default_profile_image":false,
61+
"friends_count":301,
62+
"location":"San Francisco",
63+
"screen_name":"mdeiters",
64+
"default_profile":false,
65+
"profile_background_image_url_https":"https://si0.twimg.com/profile_background_images/6771536/Fresh-Grass_1600.jpg",
66+
"profile_sidebar_border_color":"BDDCAD",
67+
"id_str":"6271932",
68+
"is_translator":false,
69+
"geo_enabled":true,
70+
"url":"http://coderwall.com/mdeiters",
71+
"profile_image_url_https":"https://si0.twimg.com/profile_images/1672080012/instagram_profile_normal.jpg",
72+
"profile_use_background_image":true,
73+
"favourites_count":178,
74+
"id":6271932,
75+
"show_all_inline_media":false,
76+
"follow_request_sent":false,
77+
"notifications":false,
78+
"profile_text_color":"333333"
79+
}
80+
}
81+
}

‎spec/models/users/github/profile_spec.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
require 'rails_helper'
2323
require 'vcr_helper'
2424

25-
RSpec.describe Users::Github::Profile, type: :model do
25+
RSpec.describe Users::Github::Profile, type: :model, skip: true do
2626
it { is_expected.to belong_to :user }
2727
it { is_expected.to have_many :followers }
2828
it { is_expected.to have_many :repositories }

0 commit comments

Comments
 (0)