Skip to content

Commit 7760609

Browse files
committed
Don't swallow errors
1 parent 84ec222 commit 7760609

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

app/controllers/teams_controller.rb

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ def followed
2222
def show
2323
#FIXME
2424
show_params = params.permit(:job_id, :refresh, :callback, :id, :slug)
25-
@team = team_from_params(slug: show_params[:slug], id: show_params[:id])
25+
@team ||= team_from_params(slug: show_params[:slug], id: show_params[:id])
2626

2727
respond_to do |format|
2828
format.html do
@@ -53,8 +53,6 @@ def show
5353
render :json => response
5454
end
5555
end
56-
rescue
57-
redirect_to teamname_url(:slug => params[:id])
5856
end
5957

6058
def new

app/helpers/premium_helper.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -183,7 +183,7 @@ def default_job
183183
location: 'Anywhere',
184184
link: 'http://coderwall.com',
185185
cached_tags: 'Skilled, Awesome',
186-
tags: 'Java, TDD, Heroku',
186+
tag_list: %w(Java TDD Heroku),
187187
location_city: 'San Francisco, CA',
188188
team_id: @team.id || Team.featured.first.id
189189
)

0 commit comments

Comments
 (0)