Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

react@19 support #616

Closed
rpearce opened this issue Jun 22, 2024 · 6 comments
Closed

react@19 support #616

rpearce opened this issue Jun 22, 2024 · 6 comments
Assignees
@rpearce
Labels
chore

Comments

@rpearce
Copy link
Owner

rpearce commented Jun 22, 2024

Description

This is a TODO for me to ensure this lib has react@19 support, including allowing it in the peerDependencies.

At present, storybook is the weak link in the testing chain, as I get errors there. TBD!
@rpearce rpearce added the chore label Jun 22, 2024
@rpearce rpearce self-assigned this Jun 22, 2024
@edlerd
Copy link
Contributor

edlerd commented Dec 8, 2024

Hey there @rpearce 👋 ,

react 19 was released on December 5th, do you need help with an update to reach react 19 support?

@rpearce
Copy link
Owner Author

rpearce commented Dec 8, 2024

Hi! I'm planning on getting to it in the next couple of days, but PRs are welcome!

@edlerd
Copy link
Contributor

edlerd commented Dec 8, 2024

I opened this one for now: #784

@rpearce
Copy link
Owner Author

rpearce commented Dec 8, 2024

Thanks! I'm hosting a holiday party today and will get to it as soon as I can 🎄

@rpearce
Copy link
Owner Author

rpearce commented Dec 9, 2024

Closed by #784

@rpearce rpearce closed this as completed Dec 9, 2024
@rpearce rpearce changed the title TODO: react@19 support react@19 support Dec 9, 2024
@rpearce
Copy link
Owner Author

rpearce commented Dec 9, 2024

Confirmed this working here: https://codesandbox.io/p/sandbox/mfwrqh?file=%2Fpackage.json%3A11%2C17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rpearce rpearce

Labels
chore
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rpearce @edlerd