Chain exception cause on create failure

philwebb · cbeams · commit 98075c33c6a3 · 2012-10-24T15:47:11.000+02:00
Propogate root cause of exceptions thrown from createCollection and createMap. Issue: SPR-9285 Backport-Commit: 2e48656
diff --git a/org.springframework.core/src/main/java/org/springframework/core/CollectionFactory.java b/org.springframework.core/src/main/java/org/springframework/core/CollectionFactory.java
@@ -255,7 +255,8 @@ else if (Set.class.equals(collectionType) || Collection.class.equals(collectionT
 				return (Collection) collectionType.newInstance();
 			}
 			catch (Exception ex) {
-				throw new IllegalArgumentException("Could not instantiate Collection type: " + collectionType.getName());
+				throw new IllegalArgumentException("Could not instantiate Collection type: " +
+						collectionType.getName(), ex);
 			}
 		}
 	}
@@ -322,7 +323,8 @@ else if (MultiValueMap.class.equals(mapType)) {
 				return (Map) mapType.newInstance();
 			}
 			catch (Exception ex) {
-				throw new IllegalArgumentException("Could not instantiate Map type: " + mapType.getName());
+				throw new IllegalArgumentException("Could not instantiate Map type: " +
+						mapType.getName(), ex);
 			}
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -255,7 +255,8 @@ else if (Set.class.equals(collectionType) \|\| Collection.class.equals(collectionT`
`255`	`255`	`return (Collection) collectionType.newInstance();`
`256`	`256`	`}`
`257`	`257`	`catch (Exception ex) {`
`258`		`- throw new IllegalArgumentException("Could not instantiate Collection type: " + collectionType.getName());`
	`258`	`+ throw new IllegalArgumentException("Could not instantiate Collection type: " +`
	`259`	`+ collectionType.getName(), ex);`
`259`	`260`	`}`
`260`	`261`	`}`
`261`	`262`	`}`
`@@ -322,7 +323,8 @@ else if (MultiValueMap.class.equals(mapType)) {`
`322`	`323`	`return (Map) mapType.newInstance();`
`323`	`324`	`}`
`324`	`325`	`catch (Exception ex) {`
`325`		`- throw new IllegalArgumentException("Could not instantiate Map type: " + mapType.getName());`
	`326`	`+ throw new IllegalArgumentException("Could not instantiate Map type: " +`
	`327`	`+ mapType.getName(), ex);`
`326`	`328`	`}`
`327`	`329`	`}`
`328`	`330`	`}`