Cache uniqueDeclaredMethods

philwebb · philwebb · commit b197aed65f75 · 2013-05-02T10:35:00.000-07:00
** Probably not for Spring 4 M1 **
diff --git a/spring-beans/src/main/java/org/springframework/beans/factory/support/AbstractAutowireCapableBeanFactory.java b/spring-beans/src/main/java/org/springframework/beans/factory/support/AbstractAutowireCapableBeanFactory.java
@@ -74,6 +74,7 @@
 import org.springframework.core.ParameterNameDiscoverer;
 import org.springframework.core.PriorityOrdered;
 import org.springframework.util.ClassUtils;
+import org.springframework.util.ConcurrentReferenceHashMap;
 import org.springframework.util.ObjectUtils;
 import org.springframework.util.ReflectionUtils;
 import org.springframework.util.StringUtils;
@@ -151,6 +152,10 @@ public abstract class AbstractAutowireCapableBeanFactory extends AbstractBeanFac
 	private final Map<Class, PropertyDescriptor[]> filteredPropertyDescriptorsCache =
 			new ConcurrentHashMap<Class, PropertyDescriptor[]>(64);
 
+	/** Cache of unique declared methods **/
+	private final ConcurrentReferenceHashMap<Class, Method[]> uniqueDeclaredMethodsCache =
+			new ConcurrentReferenceHashMap<Class, Method[]>();
+
 
 	/**
 	 * Create a new AbstractAutowireCapableBeanFactory.
@@ -648,7 +653,7 @@ protected Class<?> getTypeForFactoryMethod(String beanName, RootBeanDefinition m
 		// If all factory methods have the same return type, return that type.
 		// Can't clearly figure out exact method due to type converting / autowiring!
 		int minNrOfArgs = mbd.getConstructorArgumentValues().getArgumentCount();
-		Method[] candidates = ReflectionUtils.getUniqueDeclaredMethods(factoryClass);
+		Method[] candidates = getUniqueDeclaredMethods(factoryClass);
 		Set<Class<?>> returnTypes = new HashSet<Class<?>>(1);
 		for (Method factoryMethod : candidates) {
 			if (Modifier.isStatic(factoryMethod.getModifiers()) == isStatic &&
@@ -671,6 +676,15 @@ protected Class<?> getTypeForFactoryMethod(String beanName, RootBeanDefinition m
 		}
 	}
 
+	private Method[] getUniqueDeclaredMethods(Class factoryClass) {
+		Method[] methods = this.uniqueDeclaredMethodsCache.get(factoryClass);
+		if(methods == null) {
+			methods = ReflectionUtils.getUniqueDeclaredMethods(factoryClass);
+			this.uniqueDeclaredMethodsCache.put(factoryClass, methods);
+		}
+		return methods;
+	}
+
 	/**
 	 * This implementation attempts to query the FactoryBean's generic parameter metadata
 	 * if present to determine the object type. If not present, i.e. the FactoryBean is
