AbstractDriverBasedDataSource does not rely on Properties chaining anymore

jhoeller · jhoeller · commit f3d0beb95503 · 2013-01-18T19:07:46.000+01:00
Issue: SPR-9461
diff --git a/org.springframework.jdbc/src/main/java/org/springframework/jdbc/datasource/AbstractDriverBasedDataSource.java b/org.springframework.jdbc/src/main/java/org/springframework/jdbc/datasource/AbstractDriverBasedDataSource.java
@@ -139,15 +139,18 @@ public Connection getConnection(String username, String password) throws SQLExce
 	 * @see java.sql.Driver#connect(String, java.util.Properties)
 	 */
 	protected Connection getConnectionFromDriver(String username, String password) throws SQLException {
-		Properties props = new Properties();
-		props.putAll(getConnectionProperties());
+		Properties mergedProps = new Properties();
+		Properties connProps = getConnectionProperties();
+		if (connProps != null) {
+			mergedProps.putAll(connProps);
+		}
 		if (username != null) {
-			props.setProperty("user", username);
+			mergedProps.setProperty("user", username);
 		}
 		if (password != null) {
-			props.setProperty("password", password);
+			mergedProps.setProperty("password", password);
 		}
-		return getConnectionFromDriver(props);
+		return getConnectionFromDriver(mergedProps);
 	}
 
 	/**
