[fix] reports with non-ascii chars close codecov#56

stevepeak · stevepeak · commit f66acf0cdc97 · 2016-02-14T08:41:53.000+13:00
diff --git a/codecov/__init__.py b/codecov/__init__.py
@@ -583,10 +583,7 @@ def main(*argv, **kwargs):
             write("  --> Found %s adjustments" % (adjustments.count('\n') - adjustments.count('\n\n') - 1))
             reports = str(reports) + '\n# path=fixes\n' + str(adjustments) + '<<<<<< EOF'
 
-        try:
-            reports.encode('ascii', 'replace')
-        except:
-            reports = remove_ascii('', reports)
+        reports = remove_ascii('', reports)
 
         result = ''
         if codecov.dump:
diff --git a/tests/non-ascii-report.txt b/tests/non-ascii-report.txt
@@ -0,0 +1 @@
+alt-j∆apple
diff --git a/tests/test.py b/tests/test.py
@@ -334,6 +334,11 @@ def test_not_jacoco(self):
         self.assertEqual(res[0], '# path=tests/coverage.xml')
         self.assertEqual(res[1], '<data>')
 
+    def test_non_ascii(self):
+        res = self.run_cli(file='tests/non-ascii-report.txt', **self.defaults)
+        res = res['reports'].split('<<<<<< network\n')[1].splitlines()
+        self.assertEqual(res[1], 'alt-japple')
+
     def test_run_coverage(self):
         self.skipTest('Not sure how to pull off atm')
         with open(self.coverage, 'w+') as f:
