Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: rubocop/rubocop
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.75.3
Choose a base ref
...
head repository: rubocop/rubocop
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.75.4
Choose a head ref
  • 20 commits
  • 93 files changed
  • 5 contributors

Commits on Apr 22, 2025

  1. Reset the docs version

    bbatsov committed Apr 22, 2025
    Configuration menu
    Copy the full SHA
    f44b15c View commit details
    Browse the repository at this point in the history
  2. Fix false positives for Style/RedundantParentheses

    Follow-up to #14067 (comment)
    The fix in #14093 had been overlooked.
    
    This PR fixes false positives for `Style/RedundantParentheses`
    when parens around basic conditional as the second argument of a parenthesized method call.
    koic committed Apr 22, 2025
    Configuration menu
    Copy the full SHA
    edbc2c6 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #14110 from koic/fix_false_positives_for_style_red…

    …undant_parentheses
    
    Fix false positives for `Style/RedundantParentheses`
    koic authored Apr 22, 2025
    Configuration menu
    Copy the full SHA
    4138348 View commit details
    Browse the repository at this point in the history
  4. [Fix #14111] Fix an error for Style/SafeNavigation

    This PR fixes an error for `Style/SafeNavigation`
    when the RHS of `&&` is a complex `||` expression composed of `&&` conditions.
    
    Fixes #14111
    koic authored and bbatsov committed Apr 22, 2025
    Configuration menu
    Copy the full SHA
    378939b View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2025

  1. [Fix #13611] Enable Lint/CircularArgumentReference on Ruby 3.4

    It is allowed syntax again, without a warning. Conceptually it is very close to `Lint/SelfAssignment`,
    so I would say it makes sense to just enable this again.
    Earlopain committed Apr 24, 2025
    Configuration menu
    Copy the full SHA
    b383d6c View commit details
    Browse the repository at this point in the history
  2. Merge pull request #14115 from Earlopain/circular-arguments

    [Fix #13611] Enable `Lint/CircularArgumentReference` on Ruby 3.4
    koic authored Apr 24, 2025
    Configuration menu
    Copy the full SHA
    066e7a2 View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2025

  1. Run Ruby 3.4 examples with prism by default

    `parser` can't correctly analyze 3.4, so it requires `broken_on: :parser` in a bunch of places.
    
    Users don't run with `parser` on Ruby 3.4 anymore, `prism` is choosen automatically. So, there's no
    reason to not just do the same in tests.
    Earlopain authored and bbatsov committed Apr 25, 2025
    Configuration menu
    Copy the full SHA
    80165c2 View commit details
    Browse the repository at this point in the history
  2. [Fix #14120] Fix false positives for Style/RedundantParentheses

    This PR fixes false positives for `Style/RedundantParentheses`
    when parens around unparenthesized method call as the second argument of a parenthesized method call.
    
    Fixes #14120.
    koic authored and bbatsov committed Apr 25, 2025
    Configuration menu
    Copy the full SHA
    df5b195 View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2025

  1. Fix linked pr in changelog entry for "Extension plugin is loaded auto…

    …matically with require 'rubocop/rspec/support'"
    Zopolis4 committed Apr 26, 2025
    Configuration menu
    Copy the full SHA
    a7737c2 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #14125 from Zopolis4/happenst

    Fix linked pr in changelog entry for "Extension plugin is loaded automatically with require 'rubocop/rspec/support'"
    koic authored Apr 26, 2025
    Configuration menu
    Copy the full SHA
    4a61156 View commit details
    Browse the repository at this point in the history
  3. [Fix #14123] Fix an error for Lint/BooleanSymbol

    This PR fixes an infinite loop error for `Lint/BooleanSymbol`
    when using the rocket hash syntax with a boolean symbol key.
    
    Fixes #14123.
    koic committed Apr 26, 2025
    Configuration menu
    Copy the full SHA
    7dea554 View commit details
    Browse the repository at this point in the history
  4. Merge pull request #14126 from koic/fix_an_error_lint_boolean_symbol

    [Fix #14123] Fix an error for `Lint/BooleanSymbol`
    koic authored Apr 26, 2025
    Configuration menu
    Copy the full SHA
    d3f6b08 View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2025

  1. [Fix #14129] Fix false positives for Style/ArgumentsForwarding

    This PR fixes false positives for `Style/ArgumentsForwarding`
    when using default positional arg, keyword arg, and block arg in Ruby 3.1.
    
    Fixes #14129.
    koic committed Apr 27, 2025
    Configuration menu
    Copy the full SHA
    3aadb46 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #14130 from koic/fix_false_positive_for_style_argu…

    …ments_forwarding_cop
    
    [Fix #14129] Fix false positives for `Style/ArgumentsForwarding`
    koic authored Apr 27, 2025
    Configuration menu
    Copy the full SHA
    a2f38ce View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2025

  1. Fix an error for Style/ComparableBetween when comparing the value w…

    …ith itself
    
    The code doesn't make much sense, but currently it errors since both entries
    in the array get rejected.
    Earlopain authored and bbatsov committed Apr 28, 2025
    Configuration menu
    Copy the full SHA
    7d1070b View commit details
    Browse the repository at this point in the history
  2. Fix Style/ClassAndModuleChildren cop error on tab-intended compacta…

    …ble modules
    
    Before these changes most of weirdly-tab-intended programms like this
    
    ```ruby
      module A
      \tmodule B
      \tmodule C
      \tbody
      \tend
      \tend
      end
    ```
    
    were producing this error
    
    ```bash
    Parser::ClobberingError:
           Parser::Source::TreeRewriter detected clobbering
         # ./lib/rubocop/cop/correctors/alignment_corrector.rb:48:in `autocorrect_line'
         # ./lib/rubocop/cop/correctors/alignment_corrector.rb:25:in `block in correct'
         # ./lib/rubocop/cop/correctors/alignment_corrector.rb:102:in `block in each_line'
         # ./lib/rubocop/cop/correctors/alignment_corrector.rb:101:in `each_line'
         # ./lib/rubocop/cop/correctors/alignment_corrector.rb:101:in `each_line'
         # ./lib/rubocop/cop/correctors/alignment_corrector.rb:24:in `correct'
    ```
    
    This bug was found by `rubocop-nightly`.
    viralpraxis authored and bbatsov committed Apr 28, 2025
    Configuration menu
    Copy the full SHA
    f669bb1 View commit details
    Browse the repository at this point in the history
  3. [Fix #14116] Make Style/TrailingCommaInArguments cop aware of trail…

    …ing commans in `[]` method call
    
    Resolves #14116
    
    This commit updates the `Style/TrailingCommaInArguments` cop to be aware of
    trailing commas in `[]` method calls.
    viralpraxis authored and bbatsov committed Apr 28, 2025
    Configuration menu
    Copy the full SHA
    c9d38e1 View commit details
    Browse the repository at this point in the history
  4. Fix Lint/LiteralAsCondition autocorrect when a literal is the condi…

    …tion of an elsif followed by an else
    Zopolis4 authored and bbatsov committed Apr 28, 2025
    Configuration menu
    Copy the full SHA
    da245af View commit details
    Browse the repository at this point in the history
  5. Update Changelog

    bbatsov committed Apr 28, 2025
    Configuration menu
    Copy the full SHA
    4ad182c View commit details
    Browse the repository at this point in the history
  6. Cut 1.75.4

    bbatsov committed Apr 28, 2025
    Configuration menu
    Copy the full SHA
    eeda3b2 View commit details
    Browse the repository at this point in the history
Loading