Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: rubocop/rubocop-rails
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v2.30.3
Choose a base ref
...
head repository: rubocop/rubocop-rails
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v2.31.0
Choose a head ref
  • 14 commits
  • 34 files changed
  • 4 contributors

Commits on Feb 28, 2025

  1. Future-proof Rails/Output for itblock

    This way it's just checking for a block body instead of caring about the specific type
    Earlopain committed Feb 28, 2025
    Configuration menu
    Copy the full SHA
    84d09f5 View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2025

  1. Configuration menu
    Copy the full SHA
    332ef79 View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2025

  1. Don't load the active_support blank core extension

    Rubocop already defined its own `blank?` method (🙁),
    so ruby always warns when it is loaded again.
    
    There's no real point in using the extension though, so just not using it seems ideal.
    Earlopain committed Mar 12, 2025
    Configuration menu
    Copy the full SHA
    d66f688 View commit details
    Browse the repository at this point in the history
  2. Avoid warnings about redefined methods in EnforceSuperclass module

    Fix #1465
    
    This change avoids the printing of warnings about some methods
    (`included`, `on_class`, and `on_send`) of the
    `RuboCop::Cop::EnforceSuperclass` module being redefined. These warnings
    are printed because, in addition to the definition of that module here
    in `rubocop-rails`, that module is first [also defined in `rubocop`][1].
    (The module has been extracted to `rubocop-rails`, but is also left in
    `rubocop`, for backwards compatibility.)
    
    [1]: https://github.com/rubocop/rubocop/blob/v1.73.2/lib/rubocop/cop/mixin/enforce_superclass.rb
    
    This change avoids the warnings by first undefining the
    `RuboCop::Cop::EnforceSuperclass` module (the one from `rubocop`) before
    then redefining that module here in `rubocop-rails`.
    davidrunger committed Mar 12, 2025
    Configuration menu
    Copy the full SHA
    f5c8ee8 View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2025

  1. Merge pull request #1466 from davidrunger/avoid-warnings-about-redefi…

    …ned-methods
    
    Avoid warnings about redefined methods in EnforceSuperclass module
    koic authored Mar 14, 2025
    Configuration menu
    Copy the full SHA
    2c65962 View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2025

  1. Merge pull request #1467 from Earlopain/less-rails-extensions

    Don't load the active_support `blank` core extension
    koic authored Mar 15, 2025
    Configuration menu
    Copy the full SHA
    8056bdc View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2025

  1. Suppress RuboCop's offense

    This commit suppresses the following RuboCop's offense:
    
    ```console
    $ bundle exec rubocop
    (snip)
    
    lib/rubocop/cop/rails/eager_evaluation_log_message.rb:48:23:
    C: [Correctable] Style/RedundantFormat: Use MSG directly instead of format.
                message = format(MSG)
                          ^^^^^^^^^^^
    
    301 files inspected, 1 offense detected, 1 offense autocorrectable
    ```
    koic committed Mar 26, 2025
    Configuration menu
    Copy the full SHA
    930584a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c222756 View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2025

  1. Merge pull request #1460 from Earlopain/future-proof-rails-output

    Future-proof `Rails/Output` for `itblock`
    koic authored Mar 27, 2025
    Configuration menu
    Copy the full SHA
    3fbbca6 View commit details
    Browse the repository at this point in the history
  2. Support it block parameter in Rails cops

    This PR supports `it` block parameter in `Rails` cops.
    
    Closes #1413
    koic committed Mar 27, 2025
    Configuration menu
    Copy the full SHA
    72155fd View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2025

  1. Merge pull request #1471 from koic/support_itblock_in_rails_cops

    Support `it` block parameter in `Rails` cops
    koic authored Mar 28, 2025
    Configuration menu
    Copy the full SHA
    2420d70 View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2025

  1. Merge pull request #1469 from hatsu38/fix-broken-Rails_ArelStar-adoc

    [Fix #1353] Fix incorrect escaping of asterisk in docs and comments
    koic authored Mar 29, 2025
    Configuration menu
    Copy the full SHA
    6b32cfb View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2025

  1. Update Changelog

    koic committed Apr 1, 2025
    Configuration menu
    Copy the full SHA
    85f2a72 View commit details
    Browse the repository at this point in the history
  2. Cut 2.31.0

    koic committed Apr 1, 2025
    Configuration menu
    Copy the full SHA
    87dd3e3 View commit details
    Browse the repository at this point in the history
Loading