From 310cb156b924ac655b19a7b9b0e6febf7aa08284 Mon Sep 17 00:00:00 2001 From: Hiroshi SHIBATA Date: Wed, 24 Jan 2024 11:45:36 +0900 Subject: [PATCH 1/5] Use macos-arm-oss and latest versions for test and benchmark CI --- .github/workflows/benchmark.yml | 3 ++- .github/workflows/ci.yml | 1 + 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/benchmark.yml b/.github/workflows/benchmark.yml index 3b67d1da..5a31c35c 100644 --- a/.github/workflows/benchmark.yml +++ b/.github/workflows/benchmark.yml @@ -27,7 +27,8 @@ jobs: matrix: os: - ubuntu-latest - - macos-11 + - macos-latest + - macos-arm-oss - windows-latest ruby: ${{ fromJson(needs.ruby-versions.outputs.versions) }} include: diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index ef6ba7cb..9227cb1d 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -28,6 +28,7 @@ jobs: os: - ubuntu-latest - macos-latest + - macos-arm-oss - windows-latest ruby: ${{ fromJson(needs.ruby-versions.outputs.versions) }} include: From 26bc4990156cd84106a63800e42c02bd700eb9e5 Mon Sep 17 00:00:00 2001 From: Hiroshi SHIBATA Date: Wed, 24 Jan 2024 11:50:25 +0900 Subject: [PATCH 2/5] Exclude Ruby 2.5 with Apple Silicon --- .github/workflows/ci.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 9227cb1d..cd6f20b0 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -35,6 +35,7 @@ jobs: - { os: windows-latest , ruby: mingw } - { os: windows-latest , ruby: mswin } exclude: + - { os: macos-arm-oss , ruby: "2.5" } - { os: windows-latest , ruby: debug } - { os: windows-latest , ruby: truffleruby } - { os: windows-latest , ruby: truffleruby-head } From b2a948037c16785e27ace99f701dd1e069936b7e Mon Sep 17 00:00:00 2001 From: Yusuke Endoh Date: Thu, 15 Feb 2024 21:30:16 +0900 Subject: [PATCH 3/5] Support Ruby 3.4's new error message format Ruby 3.4 will use a single quote instead of a backtrick as an open quote. https://bugs.ruby-lang.org/issues/16495 --- test/bigdecimal/test_bigdecimal.rb | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/test/bigdecimal/test_bigdecimal.rb b/test/bigdecimal/test_bigdecimal.rb index d44bcdaf..cae33751 100644 --- a/test/bigdecimal/test_bigdecimal.rb +++ b/test/bigdecimal/test_bigdecimal.rb @@ -290,7 +290,7 @@ def test_BigDecimal_with_exception_keyword end def test_s_ver - assert_raise_with_message(NoMethodError, /undefined method `ver'/) { BigDecimal.ver } + assert_raise_with_message(NoMethodError, /undefined method [`']ver'/) { BigDecimal.ver } end def test_s_allocate @@ -302,7 +302,7 @@ def test_s_allocate end def test_s_new - assert_raise_with_message(NoMethodError, /undefined method `new'/) { BigDecimal.new("1") } + assert_raise_with_message(NoMethodError, /undefined method [`']new'/) { BigDecimal.new("1") } end def test_s_interpret_loosely @@ -2067,7 +2067,7 @@ def test_dup def test_new_subclass c = Class.new(BigDecimal) - assert_raise_with_message(NoMethodError, /undefined method `new'/) { c.new(1) } + assert_raise_with_message(NoMethodError, /undefined method [`']new'/) { c.new(1) } end def test_bug6406 From c9aa2a5e19a4dcbc76a83720f8f0d101232d0dab Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?R=C3=A9my=20Hannequin?= Date: Fri, 16 Feb 2024 10:46:58 +0100 Subject: [PATCH 4/5] Rename `rake spec` with `rake test` in documentation `rake spec` is not defined in Rake tasks (`rake -T`). `rake test` runs the tests. This updates the documentation to help newcomers to run the test suite locally. --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 927cce11..e9cbf7b1 100644 --- a/README.md +++ b/README.md @@ -53,7 +53,7 @@ TODO: Write usage instructions here ## Development After checking out the repo, run `bin/setup` to install dependencies. -Then, run `rake spec` to run the tests. +Then, run `rake test` to run the tests. You can also run `bin/console` for an interactive prompt that will allow you to experiment. From cbb53692f163babcb8360ed3a1f50068f315886c Mon Sep 17 00:00:00 2001 From: Hiroshi SHIBATA Date: Thu, 14 Mar 2024 16:21:01 +0900 Subject: [PATCH 5/5] Bump up 3.1.7 --- ext/bigdecimal/bigdecimal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ext/bigdecimal/bigdecimal.c b/ext/bigdecimal/bigdecimal.c index 98d5094f..3e14364a 100644 --- a/ext/bigdecimal/bigdecimal.c +++ b/ext/bigdecimal/bigdecimal.c @@ -31,7 +31,7 @@ #include "bits.h" #include "static_assert.h" -#define BIGDECIMAL_VERSION "3.1.6" +#define BIGDECIMAL_VERSION "3.1.7" /* #define ENABLE_NUMERIC_STRING */