Move logic for old posts from Document to Linter

stomar · stomar · commit a64594642128 · 2018-05-09T21:32:09.000+02:00
Handle exceptions for old posts in the Linter class,
not in Linter::Document. This helps in making the
methods do what their name implies.
diff --git a/lib/linter.rb b/lib/linter.rb
@@ -72,10 +72,13 @@ def check
 
     posts.each do |doc|
       errors[doc] << "missing author variable"  if doc.author_missing?
-      errors[doc] << "missing translator variable"  if doc.translator_missing?
-      errors[doc] << "missing or invalid date variable"  if doc.date_missing?
       errors[doc] << "date mismatch between filename and YAML front matter (UTC)"  if doc.date_mismatch?
       errors[doc] << "wrong time zone offset in YAML front matter (not UTC)"  if doc.yaml_date_not_utc?
+
+      unless doc.old_post?
+        errors[doc] << "missing translator variable"  if doc.translator_missing?
+        errors[doc] << "missing or invalid date variable"  if doc.date_missing?
+      end
     end
   end
 
diff --git a/lib/linter/document.rb b/lib/linter/document.rb
@@ -32,20 +32,16 @@ def author_missing?
     end
 
     def translator_missing?
-      return nil  if old_post?
-
       !yaml.has_key?("translator")
     end
 
     # date missing or invalid
     def date_missing?
-      return nil  if old_post?
-
       yaml["date"].nil? || !yaml["date"].respond_to?(:getutc)
     end
 
     def date_mismatch?
-      return nil  if (date_missing? || old_post?)
+      return nil  if date_missing?
 
       yaml_date_utc != slug_date
     end
@@ -59,7 +55,7 @@ def slug_date
     end
 
     def yaml_date_not_utc?
-      return nil  if (date_missing? || old_post?)
+      return nil  if date_missing?
 
       yaml["date"].utc_offset != 0
     end
