Refactor Linter::Release

stomar · stomar · commit f192967e46d7 · 2020-01-01T14:37:43.000+01:00
Use regular expression for post URL only once, introduce some methods.
diff --git a/lib/linter/release.rb b/lib/linter/release.rb
@@ -20,17 +20,15 @@ def initialize(data)
     #   file: en/news/_posts/2019-12-25-ruby-2-7-0-released.md
     #
     def post_filename
-      %r{\A/en/news/(?<yyyy>\d{4})/(?<mm>\d\d)/(?<dd>\d\d)/(?<name>[^/]*)/\Z} =~ post
-
-      "en/news/_posts/#{yyyy}-#{mm}-#{dd}-#{name}.md"
+      "en/news/_posts/#{post_date_string}-#{post_title}.md"
     end
 
     # Returns true if the post URL does not match the expected format:
     #
     #   /en/news/yyyy/mm/dd/ruby-2-7-0-released/
     #
     def post_url_invalid?
-      !%r{\A/en/news/\d{4}/\d\d/\d\d/[^/]*/\Z}.match?(post)
+      !post_url_data
     end
 
     # Returns true if the release date and the post date do not match.
@@ -50,11 +48,37 @@ def post_missing?
 
     private
 
+    # Returns the MatchData for date and title parts of the post URL,
+    # or +nil+ if the post URL does not match the expected format.
+    #
+    # The MatchData includes the named captures yyyy, mm, dd, and title.
+    #
+    # Example URL:
+    #
+    #   /en/news/2019/12/25/ruby-2-7-0-released/
+    #
+    def post_url_data
+      pattern = %r{\A/en/news/(?<yyyy>\d{4})/(?<mm>\d\d)/(?<dd>\d\d)/(?<title>[^/]*)/\z}
+
+      pattern.match(post)
+    end
+
     # The date corresponding to the given post URL.
     def post_date_string
-      %r{\A/en/news/(?<yyyy>\d{4})/(?<mm>\d\d)/(?<dd>\d\d)/(?<name>[^/]*)/\Z} =~ post
+      return  unless post_url_data
+
+      yyyy = post_url_data[:yyyy]
+      mm = post_url_data[:mm]
+      dd = post_url_data[:dd]
 
       "#{yyyy}-#{mm}-#{dd}"
     end
+
+    # The post title corresponding to the given post URL.
+    def post_title
+      return  unless post_url_data
+
+      post_url_data[:title]
+    end
   end
 end
