Skip to content

Update Turkish translation from welcome page burger menu "Home" button in mobile view #2295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
hasantezcan opened this issue Dec 4, 2019 · 6 comments
Closed

Update Turkish translation from welcome page burger menu "Home" button in mobile view #2295

hasantezcan opened this issue Dec 4, 2019 · 6 comments

Comments

@hasantezcan
Copy link
Contributor

I think that is forgotten. It has to be fix.
@ismailarilik
Copy link
Member

It cannot be changed since it is in a common place for all translations: https://github.com/ruby/www.ruby-lang.org/blob/master/_layouts/default.html#L46

@ismailarilik ismailarilik reopened this Dec 5, 2019
@ismailarilik
Copy link
Member

But "Home" navigation link may be included in _config.yml just like any other links such as "Download" and "Documentation". @ruby/www-ruby-lang-org-editorial what are your opinions about this idea?

@hasantezcan
Copy link
Contributor Author

Definitely. We can move the "Home" section to _config.yml. In this way we solved that hardcoded problem. By the way the other languages translations are needed it that changes too.

@stomar
Copy link
Contributor

stomar commented Dec 15, 2019

I prepared a fix in #2312.

@hasantezcan
Copy link
Contributor Author

I added the Turkish translation.
#2330

@stomar
Copy link
Contributor

stomar commented Dec 25, 2019

Fixed with #2312 and #2330.

@stomar stomar closed this as completed Dec 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@stomar @ismailarilik @hasantezcan