Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: ruby-concurrency/concurrent-ruby
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.3.3
Choose a base ref
...
head repository: ruby-concurrency/concurrent-ruby
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.3.4
Choose a head ref
  • 10 commits
  • 10 files changed
  • 4 contributors

Commits on Jul 9, 2024

  1. Configuration menu
    Copy the full SHA
    cadc8de View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2024

  1. Configuration menu
    Copy the full SHA
    6f7c91a View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2024

  1. Fix the doc of Concurrent.available_processor_count

    Currently, the doc says that this methods returns `nil` if there is
    no cpu_quota, but actually not.
    https://github.com/ruby-concurrency/concurrent-ruby/blob/6f7c91ab5a4e99d850f69c958572a536426277e8/lib/concurrent-ruby/concurrent/utility/processor_counter.rb#L30
    
    This PR fixes the doc to match the behavior.
    
    Co-authored-by: Benoit Daloze <eregontp@gmail.com>
    y-yagi and eregon committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    cbee215 View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2024

  1. Fix the return value of Concurrent.available_processor_count when `…

    …cpu.cfs_quota_us` is -1
    
    I tried to use `Concurrent.available_processor_count` in `parallel`
    gem, but we got some feedback `Concurrent.available_processor_count`
    returned a negative value.
    grosser/parallel#348 (comment)
    grosser/parallel#349 (comment)
    
    According to the https://docs.kernel.org/scheduler/sched-bwc.html#management,
    The default value of `cpu.cfs_quota_us` is -1. In that case,
    cgroup does not adhere to any CPU time restrictions.
    
    This PR adds the case of `cpu.cfs_quota_us` is -1 to `#cpu_quota`
    to return processor count from `Concurrent.available_processor_count`
    in that case.
    y-yagi authored and eregon committed Aug 10, 2024
    Configuration menu
    Copy the full SHA
    98d0f16 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e671fec View commit details
    Browse the repository at this point in the history
  3. 1.3.4

    eregon committed Aug 10, 2024
    Configuration menu
    Copy the full SHA
    8fefd59 View commit details
    Browse the repository at this point in the history
  4. Update docs-source/signpost.md

    eregon committed Aug 10, 2024
    Configuration menu
    Copy the full SHA
    13badd0 View commit details
    Browse the repository at this point in the history
  5. Avoid require in *.gemspec files to avoid redefined constant warnings

    * Like:
    concurrent-ruby/vendor/bundle/ruby/3.2.0/gems/concurrent-ruby-1.3.4/lib/concurrent-ruby/concurrent/version.rb:2: warning: already initialized constant Concurrent::VERSION
    concurrent-ruby/lib/concurrent-ruby/concurrent/version.rb:2: warning: previous definition of VERSION was here
    eregon committed Aug 10, 2024
    Configuration menu
    Copy the full SHA
    f131214 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    09bfcd0 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    044020f View commit details
    Browse the repository at this point in the history
Loading