-
Notifications
You must be signed in to change notification settings - Fork 417
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: ruby-concurrency/concurrent-ruby
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.3.3
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: ruby-concurrency/concurrent-ruby
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.3.4
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 10 commits
- 10 files changed
- 4 contributors
Commits on Jul 9, 2024
-
Configuration menu - View commit details
-
Copy full SHA for cadc8de - Browse repository at this point
Copy the full SHA cadc8deView commit details
Commits on Aug 5, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 6f7c91a - Browse repository at this point
Copy the full SHA 6f7c91aView commit details
Commits on Aug 9, 2024
-
Fix the doc of
Concurrent.available_processor_count
Currently, the doc says that this methods returns `nil` if there is no cpu_quota, but actually not. https://github.com/ruby-concurrency/concurrent-ruby/blob/6f7c91ab5a4e99d850f69c958572a536426277e8/lib/concurrent-ruby/concurrent/utility/processor_counter.rb#L30 This PR fixes the doc to match the behavior. Co-authored-by: Benoit Daloze <eregontp@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for cbee215 - Browse repository at this point
Copy the full SHA cbee215View commit details
Commits on Aug 10, 2024
-
Fix the return value of
Concurrent.available_processor_count
when `……cpu.cfs_quota_us` is -1 I tried to use `Concurrent.available_processor_count` in `parallel` gem, but we got some feedback `Concurrent.available_processor_count` returned a negative value. grosser/parallel#348 (comment) grosser/parallel#349 (comment) According to the https://docs.kernel.org/scheduler/sched-bwc.html#management, The default value of `cpu.cfs_quota_us` is -1. In that case, cgroup does not adhere to any CPU time restrictions. This PR adds the case of `cpu.cfs_quota_us` is -1 to `#cpu_quota` to return processor count from `Concurrent.available_processor_count` in that case.
Configuration menu - View commit details
-
Copy full SHA for 98d0f16 - Browse repository at this point
Copy the full SHA 98d0f16View commit details -
Configuration menu - View commit details
-
Copy full SHA for e671fec - Browse repository at this point
Copy the full SHA e671fecView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8fefd59 - Browse repository at this point
Copy the full SHA 8fefd59View commit details -
Configuration menu - View commit details
-
Copy full SHA for 13badd0 - Browse repository at this point
Copy the full SHA 13badd0View commit details -
Avoid require in *.gemspec files to avoid redefined constant warnings
* Like: concurrent-ruby/vendor/bundle/ruby/3.2.0/gems/concurrent-ruby-1.3.4/lib/concurrent-ruby/concurrent/version.rb:2: warning: already initialized constant Concurrent::VERSION concurrent-ruby/lib/concurrent-ruby/concurrent/version.rb:2: warning: previous definition of VERSION was here
Configuration menu - View commit details
-
Copy full SHA for f131214 - Browse repository at this point
Copy the full SHA f131214View commit details -
Configuration menu - View commit details
-
Copy full SHA for 09bfcd0 - Browse repository at this point
Copy the full SHA 09bfcd0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 044020f - Browse repository at this point
Copy the full SHA 044020fView commit details
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v1.3.3...v1.3.4