Remove #process_commmit_data indent parameter

Simon Coffey · Simon Coffey · commit 59dd023f5c8d · 2023-01-17T11:11:21.000Z
This was introduced in [1] to handle variance in indentation when parsing commit messages; at the time the #process_commit_data method had two callers, one which used it to process log lines, and the other which used it to process the output of `git cat-file commit <SHA>`. The former sees a 4-space indent, the latter, zero. Since [2], however, the log processing has been handled by the #process_commit_log_data method, so #process_commit_data exclusively handles un-indented inputs, and we can remove the indent parameter. [1] 05117d4 [2] 97e1fff Signed-off-by: Simon Coffey <simon.coffey@futurelearn.com>
diff --git a/lib/git/lib.rb b/lib/git/lib.rb
@@ -221,10 +221,10 @@ def object_size(sha)
     def commit_data(sha)
       sha = sha.to_s
       cdata = command_lines('cat-file', 'commit', sha)
-      process_commit_data(cdata, sha, 0)
+      process_commit_data(cdata, sha)
     end
 
-    def process_commit_data(data, sha = nil, indent = 4)
+    def process_commit_data(data, sha = nil)
       hsh = {
         'sha'    => sha,
         'parent' => []
@@ -238,7 +238,7 @@ def process_commit_data(data, sha = nil, indent = 4)
         end
       end
 
-      hsh['message'] = data.collect {|line| line[indent..-1]}.join("\n") + "\n"
+      hsh['message'] = data.join("\n") + "\n"
 
       return hsh
     end
