Do not call chomp! on an IO object (#500)

jcouball · web-flow · commit 8b3bd25b01d2 · 2020-12-22T10:27:27.000-08:00
Signed-off-by: James Couball &lt;jcouball@yahoo.com&gt;
diff --git a/lib/git/lib.rb b/lib/git/lib.rb
@@ -1050,15 +1050,12 @@ def command(cmd, *opts, &block)
         @logger.debug(output)
       end
 
-      if exitstatus > 1 || (exitstatus == 1 && output != '')
-        raise Git::GitExecuteError.new(git_cmd + ':' + output.to_s)
-      end
+      raise Git::GitExecuteError, "#{git_cmd}:#{output}" if
+        exitstatus > 1 || (exitstatus == 1 && output != '')
 
-      if command_opts[:chomp]
-        output.chomp! if output
-      end
+      output.chomp! if output && command_opts[:chomp] && !block_given?
 
-      return output
+      output
     end
 
     # Takes the diff command line output (as Array) and parse it into a Hash
