fix: fix Rubocop Lint/StructNewOverride offense

jcouball · jcouball · commit 8d39fe442268 · 2025-07-02T21:33:20.000-07:00
diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
@@ -6,13 +6,6 @@
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
-# Offense count: 8
-Lint/StructNewOverride:
-  Exclude:
-    - 'tests/units/test_command_line_error.rb'
-    - 'tests/units/test_failed_error.rb'
-    - 'tests/units/test_signaled_error.rb'
-    - 'tests/units/test_timeout_error.rb'
 
 # Offense count: 2
 # Configuration parameters: AllowComments, AllowNil.
diff --git a/tests/units/test_command_line_error.rb b/tests/units/test_command_line_error.rb
@@ -4,17 +4,16 @@
 
 class TestCommandLineError < Test::Unit::TestCase
   def test_initializer
-    status = Struct.new(:to_s).new('pid 89784 exit 1')
+    status = Struct.new { def to_s = 'pid 89784 exit 1' }.new
     result = Git::CommandLineResult.new(%w[git status], status, 'stdout', 'stderr')
-
     error = Git::CommandLineError.new(result)
 
     assert(error.is_a?(Git::Error))
     assert_equal(result, error.result)
   end
 
   def test_to_s
-    status = Struct.new(:to_s).new('pid 89784 exit 1')
+    status = Struct.new { def to_s = 'pid 89784 exit 1' }.new
     result = Git::CommandLineResult.new(%w[git status], status, 'stdout', 'stderr')
 
     error = Git::CommandLineError.new(result)
diff --git a/tests/units/test_failed_error.rb b/tests/units/test_failed_error.rb
@@ -4,7 +4,7 @@
 
 class TestFailedError < Test::Unit::TestCase
   def test_initializer
-    status = Struct.new(:to_s).new('pid 89784 exit 1')
+    status = Struct.new { def to_s = 'pid 89784 exit 1' }.new
     result = Git::CommandLineResult.new(%w[git status], status, 'stdout', 'stderr')
 
     error = Git::FailedError.new(result)
@@ -13,7 +13,7 @@ def test_initializer
   end
 
   def test_to_s
-    status = Struct.new(:to_s).new('pid 89784 exit 1')
+    status = Struct.new { def to_s = 'pid 89784 exit 1' }.new
     result = Git::CommandLineResult.new(%w[git status], status, 'stdout', 'stderr')
 
     error = Git::FailedError.new(result)
diff --git a/tests/units/test_signaled_error.rb b/tests/units/test_signaled_error.rb
@@ -4,7 +4,8 @@
 
 class TestSignaledError < Test::Unit::TestCase
   def test_initializer
-    status = Struct.new(:to_s).new('pid 65628 SIGKILL (signal 9)') # `kill -9 $$`
+    # `kill -9 $$`
+    status = Struct.new { def to_s = 'pid 65628 SIGKILL (signal 9)' }.new
     result = Git::CommandLineResult.new(%w[git status], status, '', 'uncaught signal')
 
     error = Git::SignaledError.new(result)
@@ -13,7 +14,8 @@ def test_initializer
   end
 
   def test_to_s
-    status = Struct.new(:to_s).new('pid 65628 SIGKILL (signal 9)') # `kill -9 $$`
+    # `kill -9 $$`
+    status = Struct.new { def to_s = 'pid 65628 SIGKILL (signal 9)' }.new
     result = Git::CommandLineResult.new(%w[git status], status, '', 'uncaught signal')
 
     error = Git::SignaledError.new(result)
diff --git a/tests/units/test_timeout_error.rb b/tests/units/test_timeout_error.rb
@@ -4,7 +4,8 @@
 
 class TestTimeoutError < Test::Unit::TestCase
   def test_initializer
-    status = Struct.new(:to_s).new('pid 65628 SIGKILL (signal 9)') # `kill -9 $$`
+    # `kill -9 $$`
+    status = Struct.new { def to_s = 'pid 65628 SIGKILL (signal 9)' }.new
     result = Git::CommandLineResult.new(%w[git status], status, 'stdout', 'stderr')
     timeout_diration = 10
 
@@ -14,7 +15,8 @@ def test_initializer
   end
 
   def test_to_s
-    status = Struct.new(:to_s).new('pid 65628 SIGKILL (signal 9)') # `kill -9 $$`
+    # `kill -9 $$`
+    status = Struct.new { def to_s = 'pid 65628 SIGKILL (signal 9)' }.new
     result = Git::CommandLineResult.new(%w[git status], status, 'stdout', 'Waiting...')
     timeout_duration = 10
 
