Don't let Ruby auto-delete archives

adamhooper · othatbrian · commit 96c814d0c249 · 2014-12-07T19:06:54.000-06:00
diff --git a/lib/git/lib.rb b/lib/git/lib.rb
@@ -699,8 +699,14 @@ def archive(sha, file = nil, opts = {})
         opts[:add_gzip] = true
       end
       
-      file ||= Tempfile.new('archive').path
-      
+      if !file
+        tempfile = Tempfile.new('archive')
+        file = tempfile.path
+        # delete it now, before we write to it, so that Ruby doesn't delete it
+        # when it finalizes the Tempfile.
+        tempfile.close!
+      end
+
       arr_opts = []
       arr_opts << "--format=#{opts[:format]}" if opts[:format]
       arr_opts << "--prefix=#{opts[:prefix]}" if opts[:prefix]
