Fix detecting of commit message in Git::Lib::process_commit_log_data

kpd200081 · kpd200081 · commit daa54459858a · 2020-08-30T19:41:35.000+03:00
If the commit doesn't contain a message, parsing the output of "git log"
results in an error, which occures because the end of the commit message
can't be detected.

Signed-off-by: Pavel Kuznetsov &lt;kpd200081@yandex.ru&gt;
diff --git a/lib/git/lib.rb b/lib/git/lib.rb
@@ -243,6 +243,8 @@ def process_commit_log_data(data)
           next
         end
 
+        in_message = false if in_message && line[0..3] != "    "
+
         if in_message
           hsh['message'] << "#{line[4..-1]}\n"
           next
@@ -559,9 +561,10 @@ def remove(path = '.', opts = {})
     #  :author
     #  :date
     #  :no_verify
+    #  :allow_empty_message
     #
     # @param [String] message the commit message to be used
-    # @param [Array] opts the commit options to be used
+    # @param [Hash] opts the commit options to be used
     def commit(message, opts = {})
       arr_opts = []
       arr_opts << "--message=#{message}" if message
@@ -571,6 +574,7 @@ def commit(message, opts = {})
       arr_opts << "--author=#{opts[:author]}" if opts[:author]
       arr_opts << "--date=#{opts[:date]}" if opts[:date].is_a? String
       arr_opts << '--no-verify' if opts[:no_verify]
+      arr_opts << '--allow-empty-message' if opts[:allow_empty_message]
 
       command('commit', arr_opts)
     end
diff --git a/tests/units/test_log_empty_message.rb b/tests/units/test_log_empty_message.rb
@@ -0,0 +1,18 @@
+#!/usr/bin/env ruby
+require File.dirname(__FILE__) + '/../test_helper'
+
+class TestLogEmptyMessage < Test::Unit::TestCase
+  def setup
+    set_file_paths
+  end
+  
+  def test_repo_with_empty_commit_message
+     @git = Git.init(Dir.mktmpdir)
+     opts = {}
+     opts[:allow_empty] = true
+     @git.commit("test", opts)
+     opts[:allow_empty_message] = true
+     @git.commit("", opts)
+     assert_equal(2, @git.log.to_a.size)     
+  end
+end
