Skip to content

Pull without args results in unexpected operation #423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
hlascelles opened this issue Oct 25, 2019 · 6 comments · Fixed by #633
Closed

Pull without args results in unexpected operation #423

hlascelles opened this issue Oct 25, 2019 · 6 comments · Fixed by #633
Milestone
2.0.0

Comments

@hlascelles
Copy link

git.pull should do what git pull does, but it doesn't

There are a couple of other issues in this repo around pull/fetch, but I'm not sure they are the same as this one.

Consider the following code:

git.checkout("foo")
git.pull

You'd think it would do the same as this, but it doesn't.

git checkout "foo"
git pull

You must do:

branch = "foo"
git.checkout(branch)
git.pull("origin", branch)

We find this quite unexpected. Is there a rationale for it?
@stale stale bot added the wontfix label Dec 24, 2019
@stale stale bot closed this as completed Dec 31, 2019
@hlascelles
Copy link
Author

hlascelles commented Jan 3, 2020 •
edited
Loading

This is still an issue. A week over Christmas was not enough time to react! I will (re)open.

@hlascelles hlascelles mentioned this issue Jan 21, 2020
Closed
@perlun perlun reopened this Jan 21, 2020
@stale stale bot added the stale label Mar 21, 2020
@hlascelles
Copy link
Author

Still an issue.

@perlun I feel the way the gem works now is "unexpected", and breaks POLA.

Would you accept a PR to change it?

@stale stale bot removed the stale label Mar 22, 2020
@jcouball
Copy link
Member

@hlascelles I agree with your assessment.

Since this change would break backwards compatibility, it would have to be targeted to the next major release.

@hlascelles
Copy link
Author

Sounds good. (Also, remove the wontfix label. Thanks!)

@jcouball jcouball removed the wontfix label Mar 22, 2020
@stale stale bot added the stale label May 22, 2020
@hlascelles
Copy link
Author

@jcouball can this be marked with Milestone 2.0, and stalebot be configured to ignore future milestones (ot some similar config?).

@stale stale bot removed the stale label May 22, 2020
@perlun perlun added the pinned label Jun 23, 2020
@perlun perlun added this to the 2.0.0 milestone Jun 23, 2020
@ruby-git ruby-git deleted a comment from stale bot Mar 1, 2023
@ruby-git ruby-git deleted a comment from stale bot Mar 1, 2023
@ruby-git ruby-git deleted a comment from stale bot Mar 1, 2023
@jcouball jcouball removed the pinned label Mar 1, 2023
@jcouball jcouball mentioned this issue Mar 1, 2023
Merged
3 tasks
@jcouball
Copy link
Member

jcouball commented Mar 1, 2023

I am considering this a bug and not a feature change so will include the fix for it into the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.0
Development

Successfully merging a pull request may close this issue.

#pull without args should do the same as git pull without args ruby-git/ruby-git
3 participants
@hlascelles @perlun @jcouball