Skip to content

--mergessupport for Git log #788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gstokkink opened this issue Apr 10, 2025 · 4 comments · Fixed by #799
Closed

--mergessupport for Git log #788

gstokkink opened this issue Apr 10, 2025 · 4 comments · Fixed by #799

Comments

@gstokkink
Copy link

Hi,

First of all, thank you for your work on this excellent gem.

Would you consider adding support for the --merges flag when parsing the Git log? I've looked into creating a PR, but I think writing a test case would be pretty hard. I guess the default test repo then needs to include a merge commit?
@jcouball
Copy link
Member

Rather than use the default test repo, it is better to create your own repo in a temp directory as shown in this test case.

This should simplify setting up the test for your specific needs without breaking other tests. Also, it runs faster this way.

@gstokkink
Copy link
Author

Ah, that's a good idea. I'll see if I can get something working.

@jcouball jcouball mentioned this issue May 15, 2025
Merged
@jcouball
Copy link
Member

In this case, since the --merges option only filters the output and does not change the format of the output, I only tested that the option was added to git log command when appropriate.

@jcouball
Copy link
Member

This was released in git-3.1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support the git log --merges option ruby-git/ruby-git
2 participants
@jcouball @gstokkink