My bad. It should probably default to the current ENV value if there is no explicit call to Git::Config.git_ssh=

Robertt

-----Original Message-----
From: cf-pub-tools notifications@github.com
Date: Tue, 13 Jan 2015 15:41:38
To: schacon/ruby-gitruby-git@noreply.github.com
Reply-To: schacon/ruby-git reply@reply.github.com
Subject: [ruby-git] fix git ssh env usage (#212)

v1.2.8 allowed setting of GIT_SSH to point to SSH wrapper.
v1.2.9 overrides this with value of Git::Base.config.git_ssh.

We are not 100% on the v1.2.8 behavior - whether the config setting or the ENV var should take precedence.
For our purposes, the ENV var would be preferable.

This is our story in our backlog: https://www.pivotaltracker.com/story/show/86059268.
You can merge this Pull Request by running:

git pull https://github.com/cf-pub-tools/ruby-git fix_git_ssh_env_usage

Or you can view, comment on it, or merge it online at:

#212

-- Commit Summary --

• fix git ssh env usage

-- File Changes --

M lib/git/lib.rb (2)
M tests/units/test_lib.rb (21)

-- Patch Links --

https://github.com/schacon/ruby-git/pull/212.patch
https://github.com/schacon/ruby-git/pull/212.diff

Reply to this email directly or view it on GitHub:
#212

@cf-pub-tools Can you please confirm if the repo's master version works for you?

Ty!

Adding tests from PR - 14738bb

I've just verified that v1.2.9.1 works in the context where v1.2.9 didn't (I was also working on the pull request with @ericTsiliacos and fkotsian). Thanks for fixing and releasing this - we can now un-pin our dependency!