process_full_diff: Don't reencode diffs which are already UTF-8 #369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping |
|
Thanks for merging this. When the patch will be released? |
This was referenced Oct 9, 2018
Closed
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstract
I'm heavy user of https://github.com/danger/danger and it internally uses this gem.
Danger frequently refers the
git diff.I noticed when
git diffcontains multi bytes text, thefull_diff_utf8_encodedincludes invalid chars like below.I saw #276 and I could understand the background of the code.
The
command_linesmethod had been fixed for it (fe680f8) but theprocess_full_diffhad not.Changes
Do not force to encode diff patch when the encoding type of it is UTF-8.