Fix hash keys in #describe #415
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Anyone? Please let me know if you need further input - this should be an easy fix. |
Currently, the symbolized key is checked for presence and then the value for the non-symbolized one is used. This works for Hashes with indifferent access (like in rails etc.) but fails for a simple example like
```ruby
Git.open(".").describe("HEAD", abbrev: 0)
=> Git::GitExecuteError (git '--git-dir=/folder/to/repo/.git' '--work-tree=/folder/to/repo' describe '--abbrev=' 'HEAD' 2>&1:error: option `abbrev' expects a numerical value)
```
Changed all references to the symbolized version (since the method signature suggests `@param [{Symbol=>Object}]`).
Signed-off-by: Jonas Mueller <jonas-mueller@mailbox.org>
|
Ping?! |
|
Is this repository still maintained? |
cdchapman
added a commit
to pentandra/lifepreserver
that referenced
this pull request
Oct 8, 2019
Uses symbolized opts keys for #describe. See ruby-git/ruby-git#415
|
Ping |
|
Monthly ping |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Ping |
Implementation and tests required to ensure that command output encod…
|
Ping |
jcouball
approved these changes
Apr 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the symbolized key is checked for presence and then the value for the non-symbolized one is used. This works for Hashes with indifferent access (like in rails etc.) but fails for a simple example like
Changed all references to the symbolized version (since the method signature suggests
@param [{Symbol=>Object}]).Your checklist for this pull request
🚨Please review the guidelines for contributing to this repository.
Description
Please describe your pull request.