Skip to content

Add no verify for commit #426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 21 commits into from
Closed

Add no verify for commit #426

wants to merge 21 commits into from

Conversation

AgoraSecurity
Copy link
Contributor

@AgoraSecurity AgoraSecurity commented Nov 7, 2019 •
edited
Loading

In git commit, add:
-n, --no-verify
This option bypasses the pre-commit and commit-msg hooks. See also githooks(5).

Your checklist for this pull request

🚨Please review the guidelines for contributing to this repository.

  • Ensure all commits include DCO sign-off.
  • Ensure that your contributions pass unit testing.
  • Ensure that your contributions contain documentation if applicable.

Description

Add option to bypasses the pre-commit and commit-msg hooks

@AgoraSecurity AgoraSecurity changed the title Add no verify for commit [WIP] Add no verify for commit Nov 7, 2019
@AgoraSecurity AgoraSecurity changed the title [WIP] Add no verify for commit Add no verify for commit Nov 10, 2019
@AgoraSecurity
Copy link
Contributor Author

@perlun and @tarcinil -- this PR is ready for review.

@stale
Copy link

stale bot commented Jan 11, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jan 11, 2020
@AgoraSecurity
Copy link
Contributor Author

@perlun and @tarcinil -- this PR is ready for review.

@stale stale bot removed the wontfix label Jan 11, 2020
@jcouball
Copy link
Member

This change looks good, but needs unit tests and documentation updates.

@AgoraSecurity
Copy link
Contributor Author

@jcouball Sure, I'll work in unit tests and documentation updates.

By the way, if you could point me to files (example of desired updates, etc.) it will really help me.

Thanks!

@jcouball
Copy link
Member

Documentation

Our CONTRIBUTING.md says that yard docs should be added / updated on all methods though I can see that hasn't been done consistently.

I would expect the yard doc for Lib::commit to be added. A good example can be found for Lib::diff_as_hash:
https://github.com/ruby-git/ruby-git/blob/master/lib/git/lib.rb#L981-L985

I'd say that documenting this option in the README.md is optional.

Unit Testing

Unit tests can be found here:
https://github.com/ruby-git/ruby-git/tree/master/tests/units

and are run with the command:
bundle exec rake test

I don't see that tests already exist for commit which makes your job harder. Feel free to take a look at other existing tests and see if you can figure it out. I'll dig in deeper to give you more advice, but it will take me some time to get to that.

tarcinil and others added 19 commits February 21, 2020 13:53
@tarcinil @AgoraSecurity
Adding ruby-head and ruby 2.6 to Travis, removing C ext from repo (ru…
5033280 
…by-git#382)

* removing un-needed elements from travis

Signed-off-by: Vern Burton <me@vernburton.com>

* removing cext which is not supported in travis

Signed-off-by: Vern Burton <me@vernburton.com>

* using double quotes

Signed-off-by: Vern Burton <me@vernburton.com>

* adding matrix form

Signed-off-by: Vern Burton <me@vernburton.com>

* using a different matrix

Signed-off-by: Vern Burton <me@vernburton.com>

* install bundler in jruby

Signed-off-by: Vern Burton <me@vernburton.com>

* removing .jrubyrc as C extension support was deprecated in 1.7 and newer versions are missing much of the support (Source: https://github.com/jruby/jruby-cext).
adding jruby back to the standard matrix

Signed-off-by: Vern Burton <me@vernburton.com>
Signed-off-by: Agora Security <github@agora-security.com>
@singpolyma @AgoraSecurity
Add support for unshallow (ruby-git#377)
fff2dd8 
Signed-off-by: Stephen Paul Weber <singpolyma@singpolyma.net>Signed-off-by: Agora Security <github@agora-security.com>
@AgoraSecurity
Support merge-base (ruby-git#370)
6fc863b 
Signed-off-by: Evgenii Pecherkin <evgenii@toptal.com>Signed-off-by: Agora Security <github@agora-security.com>
@jcouball @AgoraSecurity
Do not allow changes to ENV to leak from test to test (ruby-git#403)
1c38db5 
Signed-off-by: James Couball <jcouball@yahoo.com>Signed-off-by: Agora Security <github@agora-security.com>
@AgoraSecurity
Allow consumers to point git binary via env var (ruby-git#416)
123d259 
By adding a new environment variable called `GIT_PATH` we can allow
consumers, that is, a user of a gem which itself uses the git gem,
to customize the location of the git binary.

Example: Having a gem called `git-tool` that uses this gem `git`, if I,
as a user wants to modify the git bin location, I could do:
```
GIT_PATH=/foo/bin git-tool bar
```

Signed-off-by: Salim Afiune <afiune@chef.io>Signed-off-by: Agora Security <github@agora-security.com>
@AgoraSecurity
Add no verify for commit
ea5cd9e 
In git commit, add:
       -n, --no-verify
           This option bypasses the pre-commit and commit-msg hooks. See also githooks(5).

Signed-off-by: Agora@Ubuntu-dev <filter@agora-security.com>
Signed-off-by: Agora Security <github@agora-security.com>
@jcouball @AgoraSecurity
Implementation and tests required to ensure that command output encod…
84a271f 
…ing does not raise an exception (ruby-git#405)

Signed-off-by: James Couball <jcouball@yahoo.com>Signed-off-by: Agora Security <github@agora-security.com>
@perlun @AgoraSecurity
Fix Stalebot settings to not auto-close old issues/PRs (ruby-git#433)
3a5d962 
Signed-off-by: Per Lundberg <perlun@gmail.com>Signed-off-by: Agora Security <github@agora-security.com>
@jcouball @AgoraSecurity
Update version for pre-release (ruby-git#435)
750e54a 
Signed-off-by: James Couball <jcouball@yahoo.com>Signed-off-by: Agora Security <github@agora-security.com>
@cyclotron3k @AgoraSecurity
Include version.rb, providing Git::VERSION (ruby-git#436)
7a3123f 
Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the
    best of my knowledge, is covered under an appropriate open
    source license and I have the right under that license to
    submit that work with modifications, whether created in whole
    or in part by me, under the same open source license (unless
    I am permitted to submit under a different license), as
    Indicated in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including
    all personal information I submit with it, including my
    sign-off) is maintained indefinitely and may be redistributed
    consistent with this project or the open source license(s)
    involved.

Signed-off-by: cyclotron3k <aidan.samuel@gmail.com>Signed-off-by: Agora Security <github@agora-security.com>
@jcouball @AgoraSecurity
Removed blank after method name to fix warning (ruby-git#439)
4cd8352 
This change fixes the warning:

Users/USER/rvm/gems/ruby-2.7.0-rc1@ruby2.7-no-rails/gems/git-1.5.0/lib/git/branch.rb:40:
warning: parentheses after method name is interpreted as an argument list, not a decomposed argument

This fix was originally proposed by @jasnow

Signed-off-by: James Couball <jcouball@yahoo.com>Signed-off-by: Agora Security <github@agora-security.com>
@jcouball @AgoraSecurity
Update instructions for making contributions (ruby-git#438)
d44b476 
The intent was to structure the instructions better without making
actual changes to the contribution rules.

Signed-off-by: James Couball <jcouball@yahoo.com>Signed-off-by: Agora Security <github@agora-security.com>
@jcouball @AgoraSecurity
Add James Couball to the maintainers list. (ruby-git#437)
e74f79c 
Add instructions for releasing the git gem
Signed-off-by: James Couball <jcouball@yahoo.com>Signed-off-by: Agora Security <github@agora-security.com>
@jcouball @AgoraSecurity
Release v1.6.0 (ruby-git#443)
a639f15 
Signed-off-by: James Couball <jcouball@yahoo.com>Signed-off-by: Agora Security <github@agora-security.com>
@yuta1024 @AgoraSecurity
Fix broken link in a PR template (ruby-git#444)
3abbdf9 
Signed-off-by: Yuta Harima <yuu725@gmail.com>Signed-off-by: Agora Security <github@agora-security.com>
@yuta1024 @AgoraSecurity
fix broken link in a PR template again (ruby-git#446)
05dbada 
Signed-off-by: Yuta Harima <yuu725@gmail.com>Signed-off-by: Agora Security <github@agora-security.com>
@a4z @AgoraSecurity
Fix describe command's dirty, abbrev, candidates, and match options (r…
703b890 
…uby-git#447)

Signed-off-by: a4z <harald.achitz@gmail.com>Signed-off-by: Agora Security <github@agora-security.com>
@mhoyer @AgoraSecurity
Fix issue with color escape codes after recent update of git binari…
6c0509a 
…es (ruby-git#427)

Signed-off-by: Marcel Hoyer <m.hoyer@cid.com>Signed-off-by: Agora Security <github@agora-security.com>
@AgoraSecurity
Add yard doc for changes in #commit
186ee2c 
Signed-off-by: Agora Security <github@agora-security.com>
@AgoraSecurity
Add function to move files
a5e7acc 
Signed-off-by: Agora Security <github@agora-security.com>
@AgoraSecurity
Add unit testing for commit with option no-verify
400ba63 
Signed-off-by: Agora Security <github@agora-security.com>
@AgoraSecurity AgoraSecurity mentioned this pull request Feb 21, 2020
Merged
3 tasks
@AgoraSecurity
Copy link
Contributor Author

Closed in favor of #454

@AgoraSecurity AgoraSecurity deleted the commit_ignore branch February 21, 2020 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@AgoraSecurity @jcouball @tarcinil @singpolyma @perlun @cyclotron3k @yuta1024 @a4z @mhoyer