From ddf048c7ae7ae42c639420eae24857167b0915ef Mon Sep 17 00:00:00 2001 From: James Couball Date: Tue, 22 Dec 2020 10:13:01 -0800 Subject: [PATCH] Do not call chomp! on an IO object Signed-off-by: James Couball --- lib/git/lib.rb | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/lib/git/lib.rb b/lib/git/lib.rb index 428976a7..3dfb81f5 100644 --- a/lib/git/lib.rb +++ b/lib/git/lib.rb @@ -1050,15 +1050,12 @@ def command(cmd, *opts, &block) @logger.debug(output) end - if exitstatus > 1 || (exitstatus == 1 && output != '') - raise Git::GitExecuteError.new(git_cmd + ':' + output.to_s) - end + raise Git::GitExecuteError, "#{git_cmd}:#{output}" if + exitstatus > 1 || (exitstatus == 1 && output != '') - if command_opts[:chomp] - output.chomp! if output - end + output.chomp! if output && command_opts[:chomp] && !block_given? - return output + output end # Takes the diff command line output (as Array) and parse it into a Hash