initial jsx error tests

rubys · rubys · commit c2d96d254a69 · 2021-01-01T11:34:04.000-05:00
diff --git a/lib/ruby2js/jsx.rb b/lib/ruby2js/jsx.rb
@@ -14,7 +14,15 @@ def self.jsx2_rb(string)
     attr_name = ''
     attr_value = ''
 
+    backtrace = ''
+
     for c in string.chars
+      if c == "\n"
+        backtrace = ''
+      else
+        backtrace += c
+      end
+
       case state
       when :text
         if c == '<'
@@ -58,7 +66,7 @@ def self.jsx2_rb(string)
         elsif c =~ /^\w$/
           element += c
         elsif c != ' '
-          raise SyntaxError.new('invalid character in element: "/"')
+          raise SyntaxError.new("invalid character in element: #{c.inspect}")
         end
 
       when :void
@@ -138,13 +146,30 @@ def self.jsx2_rb(string)
       else
         raise RangeError.new("internal state error in JSX: #{state.inspect}")
       end
+
     end
 
     case state
     when :text
       result << "_ #{text.strip.inspect}\n" unless text.strip.empty?
+
+    when :element, :attr_name, :attr_value
+      raise SyntaxError.new("unclosed element #{element.inspect}")
+
+    when :dquote, :squote
+      raise SyntaxError.new("unclosed quote in #{element.inspect}")
+
+    when :attr_expr
+      raise SyntaxError.new("unclosed value in #{element.inspect}")
+
+    else
+      raise RangeError.new("internal state error in JSX: #{state.inspect}")
     end
 
     result.join("\n")
+
+  rescue => e
+    e.set_backtrace backtrace
+    raise e
   end
 end
diff --git a/spec/jsx_spec.rb b/spec/jsx_spec.rb
@@ -50,6 +50,59 @@ def to_rb(string)
       to_rb( '<><h1/><h2/></>' ).must_equal(
         ['_ do', '_h1', '_h2', 'end'].join("\n"))
     end
+
+    describe "errors" do
+      it "should detect invalid element name" do
+        _(assert_raises {to_rb '<<'}.message).
+          must_equal 'invalid character in element name: "<"'
+      end
+
+      it "should detect invalid character after element close" do
+        _(assert_raises {to_rb '</->'}.message).
+          must_equal 'invalid character in element: "-"'
+      end
+
+      it "should detect invalid character after void element close" do
+        _(assert_raises {to_rb '<a/a>'}.message).
+          must_equal 'invalid character in element: "/"'
+      end
+
+      it "should detect invalid attribute name" do
+        _(assert_raises {to_rb '<a b/>'}.message).
+          must_equal 'invalid character in attribute name: "/"'
+      end
+
+      it "should detect missing attribute value" do
+        _(assert_raises {to_rb '<a b>'}.message).
+          must_equal 'missing "=" after attribute "b" in element "a"'
+      end
+
+      it "should detect missing attribute value quotes" do
+        _(assert_raises {to_rb '<a b=1>'}.message).
+          must_equal 'invalid value for attribute "b" in element "a"'
+      end
+
+      it "should detect unclosed element" do
+        _(assert_raises {to_rb '<a'}.message).
+          must_equal 'unclosed element "a"'
+        _(assert_raises {to_rb '<a b'}.message).
+          must_equal 'unclosed element "a"'
+        _(assert_raises {to_rb '<a b='}.message).
+          must_equal 'unclosed element "a"'
+      end
+
+      it "should detect unclosed string" do
+        _(assert_raises {to_rb '<a b="'}.message).
+          must_equal 'unclosed quote in "a"'
+        _(assert_raises {to_rb "<a b='"}.message).
+          must_equal 'unclosed quote in "a"'
+      end
+
+      it "should detect unclosed value" do
+        _(assert_raises {to_rb '<a b={x'}.message).
+          must_equal 'unclosed value in "a"'
+      end
+    end
   end
 
   describe "ruby/wunderbar to JSX" do
